Re: [PATCH v1 2/2] Implemented Amd Secure Processor device driver

2024-04-18 Thread Jan Beulich
On 10.04.2024 17:36, Andrei Semenov wrote: > Signed-off-by: Andrei Semenov Again a few nits on top of Andrew's remarks: > --- /dev/null > +++ b/xen/arch/x86/include/asm/psp-sev.h > @@ -0,0 +1,655 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * AMD Secure Encrypted Virtualization

Re: [PATCH v1 2/2] Implemented Amd Secure Processor device driver

2024-04-12 Thread Andrew Cooper
On 12/04/2024 3:49 pm, Andrei Semenov wrote: >> Can you discuss this comment: >>> CET shadow stack: adapt #CP handler??? >> some more.  What's going on? > > Yep. Actually CET Shadow Stack raised #21 exception  (near ret) on older > > versions of Xen (when I said older I talk about 4.19

Re: [PATCH v1 2/2] Implemented Amd Secure Processor device driver

2024-04-12 Thread Andrei Semenov
On 4/11/24 20:42, Andrew Cooper wrote: On 10/04/2024 4:36 pm, Andrei Semenov wrote: Signed-off-by: Andrei Semenov --- xen/arch/x86/include/asm/psp-sev.h | 655 +++ xen/drivers/Kconfig| 2 + xen/drivers/Makefile | 1 +

Re: [PATCH v1 2/2] Implemented Amd Secure Processor device driver

2024-04-11 Thread Andrew Cooper
On 10/04/2024 4:36 pm, Andrei Semenov wrote: > Signed-off-by: Andrei Semenov > --- > xen/arch/x86/include/asm/psp-sev.h | 655 +++ > xen/drivers/Kconfig| 2 + > xen/drivers/Makefile | 1 + > xen/drivers/crypto/Kconfig | 10 + >

[PATCH v1 2/2] Implemented Amd Secure Processor device driver

2024-04-10 Thread Andrei Semenov
Signed-off-by: Andrei Semenov --- xen/arch/x86/include/asm/psp-sev.h | 655 +++ xen/drivers/Kconfig| 2 + xen/drivers/Makefile | 1 + xen/drivers/crypto/Kconfig | 10 + xen/drivers/crypto/Makefile| 1 +