Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-29 Thread Jan Beulich
On 29.04.2021 15:15, Luca Fancellu wrote: > That’s great, I’m going to push the v4 for this serie soon, now that the > comment is fixed, > I can include it in the docs too, do you agree? Of course (provided the patch will not get objected to). Jan

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-29 Thread Luca Fancellu
> On 29 Apr 2021, at 14:11, Jan Beulich wrote: > > On 29.04.2021 11:50, Luca Fancellu wrote: >>> On 29 Apr 2021, at 10:04, Jan Beulich wrote: >>> On 28.04.2021 16:59, Luca Fancellu wrote: > On 27 Apr 2021, at 14:57, Jan Beulich wrote: > On 26.04.2021 17:37, Luca Fancellu wrote:

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-29 Thread Jan Beulich
On 29.04.2021 11:50, Luca Fancellu wrote: >> On 29 Apr 2021, at 10:04, Jan Beulich wrote: >> On 28.04.2021 16:59, Luca Fancellu wrote: On 27 Apr 2021, at 14:57, Jan Beulich wrote: On 26.04.2021 17:37, Luca Fancellu wrote: > @@ -120,24 +132,26 @@ typedef uint32_t grant_ref_t; >

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-29 Thread Luca Fancellu
> On 29 Apr 2021, at 10:04, Jan Beulich wrote: > > On 28.04.2021 16:59, Luca Fancellu wrote: >>> On 27 Apr 2021, at 14:57, Jan Beulich wrote: >>> On 26.04.2021 17:37, Luca Fancellu wrote: @@ -66,6 +67,7 @@ * compiler barrier will still be required. * * Introducing a

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-29 Thread Jan Beulich
On 28.04.2021 16:59, Luca Fancellu wrote: >> On 27 Apr 2021, at 14:57, Jan Beulich wrote: >> On 26.04.2021 17:37, Luca Fancellu wrote: >>> @@ -66,6 +67,7 @@ >>> * compiler barrier will still be required. >>> * >>> * Introducing a valid entry into the grant table: >>> + * @code >>> * 1.

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-28 Thread Luca Fancellu
> On 27 Apr 2021, at 14:57, Jan Beulich wrote: > > On 26.04.2021 17:37, Luca Fancellu wrote: >> --- a/docs/hypercall-interfaces/arm64.rst >> +++ b/docs/hypercall-interfaces/arm64.rst >> @@ -8,6 +8,7 @@ Starting points >> .. toctree:: >>:maxdepth: 2 >> >> + arm64/grant_tables >> >> >>

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-27 Thread Julien Grall
On 27/04/2021 14:57, Jan Beulich wrote: diff --git a/docs/hypercall-interfaces/arm64/grant_tables.rst b/docs/hypercall-interfaces/arm64/grant_tables.rst new file mode 100644 index 00..8955ec5812 --- /dev/null +++ b/docs/hypercall-interfaces/arm64/grant_tables.rst @@ -0,0 +1,8 @@ +..

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-27 Thread Jan Beulich
On 26.04.2021 17:37, Luca Fancellu wrote: > --- a/docs/hypercall-interfaces/arm64.rst > +++ b/docs/hypercall-interfaces/arm64.rst > @@ -8,6 +8,7 @@ Starting points > .. toctree:: > :maxdepth: 2 > > + arm64/grant_tables > > > Functions > diff --git

[PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-26 Thread Luca Fancellu
Modification to include/public/grant_table.h: 1) Add doxygen tags to: - Create Grant tables section - include variables in the generated documentation 2) Add .rst file for grant table for Arm64 Signed-off-by: Luca Fancellu --- v3 changes: - removed tags to skip anonymous union/struct - moved