Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-29 Thread Julien Grall
Hi Bertrand, On 29/04/2024 08:20, Bertrand Marquis wrote: From the comment in sched.h: /* * rcu_lock_domain_by_id() is more efficient than get_domain_by_id(). * This is the preferred function if the returned domain reference * is short lived, but it cannot be used if the domain

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-29 Thread Jens Wiklander
Hi Julien, On Fri, Apr 26, 2024 at 7:58 PM Julien Grall wrote: > > Hi Jens, > > On 26/04/2024 09:47, Jens Wiklander wrote: > > +static void notif_irq_enable(void *info) > > +{ > > +struct notif_irq_info *irq_info = info; > > + > > +irq_info->ret = setup_irq(irq_info->irq, 0,

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-29 Thread Jens Wiklander
Hi Bertrand, On Mon, Apr 29, 2024 at 9:20 AM Bertrand Marquis wrote: [...] > >> +static void notif_irq_handler(int irq, void *data) > >> +{ > >> +const struct arm_smccc_1_2_regs arg = { > >> +.a0 = FFA_NOTIFICATION_INFO_GET_64, > >> +}; > >> +struct arm_smccc_1_2_regs resp; >

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-29 Thread Jens Wiklander
Hi Julien, On Fri, Apr 26, 2024 at 9:07 PM Julien Grall wrote: > > Hi Jens, > > On 26/04/2024 09:47, Jens Wiklander wrote: > > diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c > > index d7306aa64d50..5224898265a5 100644 > > --- a/xen/arch/arm/irq.c > > +++ b/xen/arch/arm/irq.c > > @@ -155,7

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-29 Thread Bertrand Marquis
Hi Julien, > On 26 Apr 2024, at 21:07, Julien Grall wrote: > > Hi Jens, > > On 26/04/2024 09:47, Jens Wiklander wrote: >> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c >> index d7306aa64d50..5224898265a5 100644 >> --- a/xen/arch/arm/irq.c >> +++ b/xen/arch/arm/irq.c >> @@ -155,7 +155,7

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Julien Grall
Hi Jens, On 26/04/2024 09:47, Jens Wiklander wrote: diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index d7306aa64d50..5224898265a5 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -155,7 +155,7 @@ void __init init_IRQ(void) { /* SGIs are always edge-triggered

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Julien Grall
Hi Bertrand, On 26/04/2024 10:20, Bertrand Marquis wrote: +static inline struct domain *ffa_get_domain_by_vm_id(uint16_t vm_id) +{ +/* -1 to match ffa_get_vm_id() */ +return get_domain_by_id(vm_id - 1); +} + I think there is a global discussion to have on using get_domain_by_vm_id or

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Julien Grall
Hi Jens, On 26/04/2024 09:47, Jens Wiklander wrote: +static void notif_irq_enable(void *info) +{ +struct notif_irq_info *irq_info = info; + +irq_info->ret = setup_irq(irq_info->irq, 0, irq_info->action); In v2, you were using request_irq(). But now you seem to be open-coding it. Can

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Bertrand Marquis
Hi Jens, > On 26 Apr 2024, at 15:02, Jens Wiklander wrote: > > On Fri, Apr 26, 2024 at 2:41 PM Bertrand Marquis > wrote: >> >> Hi Jens, >> >>> On 26 Apr 2024, at 14:32, Jens Wiklander wrote: >>> >>> Hi Bertrand, >>> >>> On Fri, Apr 26, 2024 at 2:19 PM Bertrand Marquis >>> wrote:

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Jens Wiklander
On Fri, Apr 26, 2024 at 2:41 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 26 Apr 2024, at 14:32, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Fri, Apr 26, 2024 at 2:19 PM Bertrand Marquis > > wrote: > >> > >> Hi Jens, > >> > >>> On 26 Apr 2024, at 14:11, Jens Wiklander > >>>

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Bertrand Marquis
Hi Jens, > On 26 Apr 2024, at 14:32, Jens Wiklander wrote: > > Hi Bertrand, > > On Fri, Apr 26, 2024 at 2:19 PM Bertrand Marquis > wrote: >> >> Hi Jens, >> >>> On 26 Apr 2024, at 14:11, Jens Wiklander wrote: >>> >>> Hi Bertrand, >>> >>> On Fri, Apr 26, 2024 at 11:20 AM Bertrand Marquis

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Jens Wiklander
Hi Bertrand, On Fri, Apr 26, 2024 at 2:19 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 26 Apr 2024, at 14:11, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Fri, Apr 26, 2024 at 11:20 AM Bertrand Marquis > > wrote: > >> > >> Hi Jens, > >> > >>> On 26 Apr 2024, at 10:47, Jens

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Bertrand Marquis
Hi Jens, > On 26 Apr 2024, at 14:11, Jens Wiklander wrote: > > Hi Bertrand, > > On Fri, Apr 26, 2024 at 11:20 AM Bertrand Marquis > wrote: >> >> Hi Jens, >> >>> On 26 Apr 2024, at 10:47, Jens Wiklander wrote: >>> >>> Add support for FF-A notifications, currently limited to an SP (Secure

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Jens Wiklander
Hi Bertrand, On Fri, Apr 26, 2024 at 11:20 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 26 Apr 2024, at 10:47, Jens Wiklander wrote: > > > > Add support for FF-A notifications, currently limited to an SP (Secure > > Partition) sending an asynchronous notification to a guest. > > > > Guests

Re: [XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Bertrand Marquis
Hi Jens, > On 26 Apr 2024, at 10:47, Jens Wiklander wrote: > > Add support for FF-A notifications, currently limited to an SP (Secure > Partition) sending an asynchronous notification to a guest. > > Guests and Xen itself are made aware of pending notifications with an > interrupt. The

[XEN PATCH v3 5/5] xen/arm: ffa: support notification

2024-04-26 Thread Jens Wiklander
Add support for FF-A notifications, currently limited to an SP (Secure Partition) sending an asynchronous notification to a guest. Guests and Xen itself are made aware of pending notifications with an interrupt. The interrupt handler retrieves the notifications using the FF-A ABI and deliver them