Re: [Xen-devel] [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format

On Mon, 28 May 2018 00:49:03 +0200, Takashi Sakamoto wrote: > > Hi, > > On May 28 2018 06:32, Colin King wrote: > > From: Colin Ian King > > > > The negative error return from the call to to_sndif_format is being > > assigned to an unsigned 8 bit integer and hence the

Re: [Xen-devel] [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format

Hi, On May 28 2018 06:32, Colin King wrote: From: Colin Ian King The negative error return from the call to to_sndif_format is being assigned to an unsigned 8 bit integer and hence the check for a negative value is always going to be false. Fix this by using ret as

[Xen-devel] [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format

From: Colin Ian King The negative error return from the call to to_sndif_format is being assigned to an unsigned 8 bit integer and hence the check for a negative value is always going to be false. Fix this by using ret as the error return and hence the negative error