Re: [Xen-devel] [PATCH] x86/boot: Reposition trampoline data

2019-08-27 Thread Jan Beulich
On 19.08.2019 15:42, Andrew Cooper wrote: ... to separate code from data. In particular, trampoline_realmode_entry's write to trampoline_cpu_started clobbers the I-cache line containing trampoline_protmode_entry, which won't be great for AP startup. Reformat the comments for trampoline_gdt to

Re: [Xen-devel] [PATCH] x86/boot: Reposition trampoline data

2019-08-19 Thread David Woodhouse
On Mon, 2019-08-19 at 14:42 +0100, Andrew Cooper wrote: > ... to separate code from data. In particular, > trampoline_realmode_entry's > write to trampoline_cpu_started clobbers the I-cache line containing > trampoline_protmode_entry, which won't be great for AP startup. > > Reformat the

[Xen-devel] [PATCH] x86/boot: Reposition trampoline data

2019-08-19 Thread Andrew Cooper
... to separate code from data. In particular, trampoline_realmode_entry's write to trampoline_cpu_started clobbers the I-cache line containing trampoline_protmode_entry, which won't be great for AP startup. Reformat the comments for trampoline_gdt to reduce their volume. No functional change.