Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-05 Thread Wei Liu
On Tue, Feb 04, 2020 at 04:02:38PM +, Xia, Hongyan wrote: [...] > > Keep in mind that accessing the union {pv, hvm} before knowing the > > exact variant is dangerous. > > > > Because mapcache is initialised for PV only, so it should be freed > > for > > PV only. I think you need to put it to

Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-04 Thread Xia, Hongyan
On Tue, 2020-02-04 at 12:08 +, Wei Liu wrote: > Thanks, I welcome effort to make Xen more scalable. :-) > > On Mon, Feb 03, 2020 at 06:36:53PM +, Hongyan Xia wrote: > > Rewrite the mapcache to be purely per-vCPU instead of partly per- > > vCPU > > and partly per-domain. > > > > This

Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-04 Thread Xia, Hongyan
On Tue, 2020-02-04 at 14:17 +, Andrew Cooper wrote: > On 03/02/2020 18:36, Hongyan Xia wrote: > > Rewrite the mapcache to be purely per-vCPU instead of partly per- > > vCPU > > and partly per-domain. > > > > This patch is needed to address performance issues when we start > > relying > > on

Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-04 Thread Xia, Hongyan
On Tue, 2020-02-04 at 14:00 +, Wei Liu wrote: > On Mon, Feb 03, 2020 at 06:36:53PM +, Hongyan Xia wrote: > [...] > > diff --git a/xen/arch/x86/domain_page.c > > b/xen/arch/x86/domain_page.c > > index dd32712d2f..52971d2ecc 100644 > > --- a/xen/arch/x86/domain_page.c > > +++

Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-04 Thread Andrew Cooper
On 03/02/2020 18:36, Hongyan Xia wrote: > Rewrite the mapcache to be purely per-vCPU instead of partly per-vCPU > and partly per-domain. > > This patch is needed to address performance issues when we start relying > on the mapcache, e.g., when we do not have a direct map. Currently, the >

Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-04 Thread Wei Liu
On Mon, Feb 03, 2020 at 06:36:53PM +, Hongyan Xia wrote: [...] > diff --git a/xen/arch/x86/domain_page.c b/xen/arch/x86/domain_page.c > index dd32712d2f..52971d2ecc 100644 > --- a/xen/arch/x86/domain_page.c > +++ b/xen/arch/x86/domain_page.c > @@ -69,12 +69,11 @@ void __init

Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-04 Thread Wei Liu
Thanks, I welcome effort to make Xen more scalable. :-) On Mon, Feb 03, 2020 at 06:36:53PM +, Hongyan Xia wrote: > Rewrite the mapcache to be purely per-vCPU instead of partly per-vCPU > and partly per-domain. > > This patch is needed to address performance issues when we start relying > on

[Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

2020-02-03 Thread Hongyan Xia
Rewrite the mapcache to be purely per-vCPU instead of partly per-vCPU and partly per-domain. This patch is needed to address performance issues when we start relying on the mapcache, e.g., when we do not have a direct map. Currently, the per-domain lock on the mapcache is a bottleneck for