Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-16 Thread Zhenzhong Duan
在 2018/8/16 18:37, Jan Beulich 写道: On 16.08.18 at 11:13, wrote: On 2018/8/16 15:10, Jan Beulich wrote: Have you investigated the alternative of deferring acpi_dmar_init() to a later point, or at least the part of it that needs to do PCI config space accesses? I'm not currently convinced the

Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-16 Thread Zhenzhong Duan
在 2018/8/16 18:42, Jan Beulich 写道: On 16.08.18 at 11:30, wrote: On 2018/8/16 17:13, Zhenzhong Duan wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1493,6 +1493,10 @@ void __init noreturn __start_xen(unsigned long mbi_p) generic_apic_probe(); +pt_pci_init(); + +

Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-16 Thread Jan Beulich
>>> On 16.08.18 at 11:30, wrote: > On 2018/8/16 17:13, Zhenzhong Duan wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1493,6 +1493,10 @@ void __init noreturn __start_xen(unsigned long mbi_p) generic_apic_probe(); +pt_pci_init(); +

Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-16 Thread Jan Beulich
>>> On 16.08.18 at 11:13, wrote: > On 2018/8/16 15:10, Jan Beulich wrote: >> Have you investigated the alternative of deferring acpi_dmar_init() >> to a later point, or at least the part of it that needs to do PCI >> config space accesses? I'm not currently convinced the device scope >> parsing

Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-16 Thread Zhenzhong Duan
On 2018/8/16 17:13, Zhenzhong Duan wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1493,6 +1493,10 @@ void __init noreturn __start_xen(unsigned long mbi_p)   generic_apic_probe(); +    pt_pci_init(); + +    acpi_mmcfg_init(); +   acpi_boot_init(); With the

Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-16 Thread Zhenzhong Duan
On 2018/8/16 15:10, Jan Beulich wrote: On 16.08.18 at 07:10, wrote: On a multiple pci segment system such as HPE Superdome-Flex, pci config space from nonzero segment is accessed with mmcfg during acpi parsing DMAR region. First of all - can you please write a little more helpful (to

Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-16 Thread Jan Beulich
>>> On 16.08.18 at 07:10, wrote: > On a multiple pci segment system such as HPE Superdome-Flex, pci config space > from nonzero segment is accessed with mmcfg during acpi parsing DMAR region. First of all - can you please write a little more helpful (to reviewers) patch description. I had to

[Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

2018-08-15 Thread Zhenzhong Duan
On a multiple pci segment system such as HPE Superdome-Flex, pci config space from nonzero segment is accessed with mmcfg during acpi parsing DMAR region. We need to setup mmcfg mapping before that or else drhd isn't correctly setup and devices under it fail to load in dom0. Signed-off-by: