Re: [Xen-devel] [PATCH] x86/shadow: fold p2m page accounting into sh_min_allocation()

2019-09-11 Thread Tim Deegan
At 10:34 +0200 on 05 Sep (1567679687), Jan Beulich wrote: > This is to make the function live up to the promise its name makes. And > it simplifies all callers. > > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich Acked-by: Tim Deegan ___

Re: [Xen-devel] [PATCH] x86/shadow: fold p2m page accounting into sh_min_allocation()

2019-09-06 Thread Andrew Cooper
On 05/09/2019 09:34, Jan Beulich wrote: > This is to make the function live up to the promise its name makes. And > it simplifies all callers. > > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper I haven't looked at the calculations in detail, but from an end

Re: [Xen-devel] [PATCH] x86/shadow: fold p2m page accounting into sh_min_allocation()

2019-09-06 Thread Roger Pau Monné
On Thu, Sep 05, 2019 at 10:34:47AM +0200, Jan Beulich wrote: > This is to make the function live up to the promise its name makes. And > it simplifies all callers. > > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks.

[Xen-devel] [PATCH] x86/shadow: fold p2m page accounting into sh_min_allocation()

2019-09-05 Thread Jan Beulich
This is to make the function live up to the promise its name makes. And it simplifies all callers. Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1256,29 +1256,26 @@ static unsigned int sh_min_allocation(co