Re: [Xen-devel] [PATCH] xen/Kconfig: Fix -Wformat-security when compiling with Clang

2019-06-27 Thread Andrew Cooper
On 27/06/2019 07:39, Jan Beulich wrote: On 26.06.19 at 19:36, wrote: >> Clang observes: >> >> tools/kconfig/conf.c:77:10: >> warning: format string is not a string literal (potentially insecure) >> [-Wformat-security] >> printf(_("aborted!\n\n")); >>

Re: [Xen-devel] [PATCH] xen/Kconfig: Fix -Wformat-security when compiling with Clang

2019-06-27 Thread Jan Beulich
>>> On 26.06.19 at 19:36, wrote: > Clang observes: > > tools/kconfig/conf.c:77:10: > warning: format string is not a string literal (potentially insecure) > [-Wformat-security] > printf(_("aborted!\n\n")); >^ > > And it is absolutely

Re: [Xen-devel] [PATCH] xen/Kconfig: Fix -Wformat-security when compiling with Clang

2019-06-26 Thread Doug Goldstein
On Wed, Jun 26, 2019 at 06:36:15PM +0100, Andrew Cooper wrote: > Clang observes: > > tools/kconfig/conf.c:77:10: > warning: format string is not a string literal (potentially insecure) > [-Wformat-security] > printf(_("aborted!\n\n")); >

[Xen-devel] [PATCH] xen/Kconfig: Fix -Wformat-security when compiling with Clang

2019-06-26 Thread Andrew Cooper
Clang observes: tools/kconfig/conf.c:77:10: warning: format string is not a string literal (potentially insecure) [-Wformat-security] printf(_("aborted!\n\n")); ^ And it is absolutely correct. gettext() can easily return a string with