Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Razvan Cojocaru
On 06/12/2018 03:35 PM, Razvan Cojocaru wrote: >>> @@ -210,7 +211,7 @@ static int p2m_init_altp2m(struct domain *d) >>> return -ENOMEM; >>> } >>> p2m->p2m_class = p2m_alternate; >>> -p2m->access_required = 1; >>> +p2m->access_required = hostp2m->access

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 14:35, wrote: > On 06/12/2018 03:23 PM, Jan Beulich wrote: > On 11.06.18 at 17:12, wrote: >>> --- a/xen/common/domctl.c >>> +++ b/xen/common/domctl.c >>> @@ -1094,6 +1094,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) >>> u_domctl) >>> domain_pause(d

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Razvan Cojocaru
Thanks for the review! On 06/12/2018 03:23 PM, Jan Beulich wrote: On 11.06.18 at 17:12, wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -38,6 +38,7 @@ >> #include >> #include >> #include >> +#include > > Not the least to avoid this I think ... > >> @@ -719

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Jan Beulich
>>> On 11.06.18 at 17:12, wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include Not the least to avoid this I think ... > @@ -719,6 +720,22 @@ int arch_domain_soft_reset(struct domain *d) > return ret; > }

[Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-11 Thread Razvan Cojocaru
For the hostp2m, access_required starts off as 0, then it can be set with xc_domain_set_access_required(). However, all the altp2ms set it to 1 on init, and ignore both the hostp2m and the hypercall. This patch sets access_required to the value from the hostp2m on altp2m init, and propagates the va