Re: [Xen-devel] [PATCH] xen: credit2: document that min_rqd is valid and ok to use

2020-10-26 Thread Dario Faggioli
On Mon, 2020-10-26 at 10:43 +, George Dunlap wrote: > On Thu, Mar 26, 2020 at 5:09 PM Dario Faggioli > wrote: > > diff --git a/xen/common/sched/credit2.c > > b/xen/common/sched/credit2.c > > index c7241944a8..9da51e624b 100644 > > --- a/xen/common/sched/credit2.c > > +++

Re: [Xen-devel] [PATCH] xen: credit2: document that min_rqd is valid and ok to use

2020-10-26 Thread George Dunlap
On Thu, Mar 26, 2020 at 5:09 PM Dario Faggioli wrote: > > Code is a bit involved, and it is not easy to tell that min_rqd, inside > csched2_res_pick() is actually pointing to a runqueue, when it is > dereferenced. > > Add a comment and an ASSERT() for that. > > Suggested-by: Jan Beulich >

[Xen-devel] [PATCH] xen: credit2: document that min_rqd is valid and ok to use

2020-03-26 Thread Dario Faggioli
Code is a bit involved, and it is not easy to tell that min_rqd, inside csched2_res_pick() is actually pointing to a runqueue, when it is dereferenced. Add a comment and an ASSERT() for that. Suggested-by: Jan Beulich Signed-off-by: Dario Faggioli --- Cc: Jürgen Groß ---