Re: [Xen-devel] [PATCH 02/20] tools/libxl: Don't prepare or save xc_config when soft resetting a domain

2018-03-21 Thread Andrew Cooper
On 21/03/18 16:18, Roger Pau Monné wrote: > On Mon, Mar 19, 2018 at 07:13:41PM +, Andrew Cooper wrote: >> xc_config is only used by xc_domain_create(), but by calling >> libxl__arch_domain_{prepare,save}_config() we clobber the real settings with >> the default settings. >> >> Move all data

Re: [Xen-devel] [PATCH 02/20] tools/libxl: Don't prepare or save xc_config when soft resetting a domain

2018-03-21 Thread Wei Liu
On Mon, Mar 19, 2018 at 07:13:41PM +, Andrew Cooper wrote: > xc_config is only used by xc_domain_create(), but by calling > libxl__arch_domain_{prepare,save}_config() we clobber the real settings with > the default settings. > > Move all data and calls relating to xc_domain_create() into the

Re: [Xen-devel] [PATCH 02/20] tools/libxl: Don't prepare or save xc_config when soft resetting a domain

2018-03-21 Thread Roger Pau Monné
On Mon, Mar 19, 2018 at 07:13:41PM +, Andrew Cooper wrote: > xc_config is only used by xc_domain_create(), but by calling > libxl__arch_domain_{prepare,save}_config() we clobber the real settings with > the default settings. > > Move all data and calls relating to xc_domain_create() into the

[Xen-devel] [PATCH 02/20] tools/libxl: Don't prepare or save xc_config when soft resetting a domain

2018-03-19 Thread Andrew Cooper
xc_config is only used by xc_domain_create(), but by calling libxl__arch_domain_{prepare,save}_config() we clobber the real settings with the default settings. Move all data and calls relating to xc_domain_create() into the path which calls it. As far as I can tell, soft_reset has always been