Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

2018-11-12 Thread Roger Pau Monné
On Mon, Nov 12, 2018 at 08:12:56AM -0700, Jan Beulich wrote: > >>> On 12.11.18 at 16:00, wrote: > > Yes, it's only the module list that's passed by physical address and > > then mapped using __va. How about the following description: > > > > "When booting Xen as a PVH guest the data in the PVH

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

2018-11-12 Thread Jan Beulich
>>> On 12.11.18 at 16:00, wrote: > Yes, it's only the module list that's passed by physical address and > then mapped using __va. How about the following description: > > "When booting Xen as a PVH guest the data in the PVH start info > structure is copied over to a multiboot structure and a

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

2018-11-12 Thread Roger Pau Monné
On Mon, Nov 12, 2018 at 05:40:21AM -0700, Jan Beulich wrote: > >>> On 12.11.18 at 12:49, wrote: > > On Mon, Nov 12, 2018 at 03:28:37AM -0700, Jan Beulich wrote: > >> >>> On 09.11.18 at 18:22, wrote: > >> > for ( i = 0; i < pvh_info->nr_modules; i++ ) > >> > { > >> >

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

2018-11-12 Thread Jan Beulich
>>> On 12.11.18 at 12:49, wrote: > On Mon, Nov 12, 2018 at 03:28:37AM -0700, Jan Beulich wrote: >> >>> On 09.11.18 at 18:22, wrote: >> > for ( i = 0; i < pvh_info->nr_modules; i++ ) >> > { >> > BUG_ON(entry[i].paddr >> 32); >> > BUG_ON(entry[i].cmdline_paddr >> 32);

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

2018-11-12 Thread Roger Pau Monné
On Mon, Nov 12, 2018 at 03:28:37AM -0700, Jan Beulich wrote: > >>> On 09.11.18 at 18:22, wrote: > > When booting Xen as a PVH guest the data in the PVH start info > > structure is copied over to a multiboot structure and a module list > > array that resides in the .init section of the Xen image.

Re: [Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

2018-11-12 Thread Jan Beulich
>>> On 09.11.18 at 18:22, wrote: > When booting Xen as a PVH guest the data in the PVH start info > structure is copied over to a multiboot structure and a module list > array that resides in the .init section of the Xen image. The > resulting multiboot structures are then handled to the generic

[Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

2018-11-09 Thread Roger Pau Monne
When booting Xen as a PVH guest the data in the PVH start info structure is copied over to a multiboot structure and a module list array that resides in the .init section of the Xen image. The resulting multiboot structures are then handled to the generic boot process using their physical address.