Re: [Xen-devel] [PATCH 1/2] x86emul: fix vector-length check for AVX512F scalar fused-multiply-add insns

2018-12-10 Thread Jan Beulich
>>> On 10.12.18 at 15:26, wrote: > On 10/12/2018 14:11, Jan Beulich wrote: > On 10.12.18 at 14:50, wrote: >>> On 07/12/2018 11:17, Jan Beulich wrote: The check needs to happen whenever EVEX.b is clear, not just in the memory operand case. >>> EVEX.b is a different field to EVEX.br

Re: [Xen-devel] [PATCH 1/2] x86emul: fix vector-length check for AVX512F scalar fused-multiply-add insns

2018-12-10 Thread Andrew Cooper
On 10/12/2018 14:11, Jan Beulich wrote: On 10.12.18 at 14:50, wrote: >> On 07/12/2018 11:17, Jan Beulich wrote: >>> The check needs to happen whenever EVEX.b is clear, not just in the >>> memory operand case. >> EVEX.b is a different field to EVEX.br >> >> I'm afraid that this goes back to

Re: [Xen-devel] [PATCH 1/2] x86emul: fix vector-length check for AVX512F scalar fused-multiply-add insns

2018-12-10 Thread Jan Beulich
>>> On 10.12.18 at 14:50, wrote: > On 07/12/2018 11:17, Jan Beulich wrote: >> The check needs to happen whenever EVEX.b is clear, not just in the >> memory operand case. > > EVEX.b is a different field to EVEX.br > > I'm afraid that this goes back to my original concern with the series. >

Re: [Xen-devel] [PATCH 1/2] x86emul: fix vector-length check for AVX512F scalar fused-multiply-add insns

2018-12-10 Thread Andrew Cooper
On 07/12/2018 11:17, Jan Beulich wrote: > The check needs to happen whenever EVEX.b is clear, not just in the > memory operand case. EVEX.b is a different field to EVEX.br I'm afraid that this goes back to my original concern with the series.  Having the fields named differently between our code

[Xen-devel] [PATCH 1/2] x86emul: fix vector-length check for AVX512F scalar fused-multiply-add insns

2018-12-07 Thread Jan Beulich
The check needs to happen whenever EVEX.b is clear, not just in the memory operand case. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -8526,11 +8526,9 @@ x86_emulate( case X86EMUL_OPC_EVEX_66(0x0f38, 0xbd): /*