Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 03:36:42PM +0200, Roger Pau Monné wrote: > On Mon, Jul 02, 2018 at 01:15:10PM +0100, Andrew Cooper wrote: > > On 02/07/18 11:41, Roger Pau Monné wrote: > > > On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > > >> This helper appears to have been introduced 10

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 01:15:10PM +0100, Andrew Cooper wrote: > On 02/07/18 11:41, Roger Pau Monné wrote: > > On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > >> This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb > >> "x86, hvm: Guest CPUID configuration"

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Andrew Cooper
On 02/07/18 11:41, Roger Pau Monné wrote: > On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: >> This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb >> "x86, hvm: Guest CPUID configuration" and never had any users at all. >> >> alloc_str() is actually an

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb > "x86, hvm: Guest CPUID configuration" and never had any users at all. > > alloc_str() is actually an opencoded calloc(), and now only has a single >

Re: [Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Wei Liu
On Mon, Jul 02, 2018 at 10:57:25AM +0100, Andrew Cooper wrote: > This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb > "x86, hvm: Guest CPUID configuration" and never had any users at all. > > alloc_str() is actually an opencoded calloc(), and now only has a single >

[Xen-devel] [PATCH 1/3] tools/libxc: Drop xc_cpuid_to_str()

2018-07-02 Thread Andrew Cooper
This helper appears to have been introduced 10 years ago by c/s 5f14a87ceb "x86, hvm: Guest CPUID configuration" and never had any users at all. alloc_str() is actually an opencoded calloc(), and now only has a single caller. Use calloc() directly and drop alloc_str(). Signed-off-by: Andrew