Re: [Xen-devel] [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h

2018-05-25 Thread Jan Beulich
>>> On 25.05.18 at 14:03, wrote: > On Fri, May 25, 2018 at 05:50:12AM -0600, Jan Beulich wrote: >> >>> On 24.05.18 at 18:05, wrote: >> > This is a step towards consolidating relevant data structures and >> > defines to one location. >> >> Sort of

Re: [Xen-devel] [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h

2018-05-25 Thread Andrew Cooper
On 25/05/18 14:05, Jan Beulich wrote: On 25.05.18 at 14:03, wrote: >> On Fri, May 25, 2018 at 05:50:12AM -0600, Jan Beulich wrote: >> On 24.05.18 at 18:05, wrote: This is a step towards consolidating relevant data structures and

Re: [Xen-devel] [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h

2018-05-25 Thread Wei Liu
On Fri, May 25, 2018 at 05:50:12AM -0600, Jan Beulich wrote: > >>> On 24.05.18 at 18:05, wrote: > > This is a step towards consolidating relevant data structures and > > defines to one location. > > Sort of contrary to what the patch does - it converts one instance of the >

Re: [Xen-devel] [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h

2018-05-25 Thread Wei Liu
On Fri, May 25, 2018 at 11:31:17AM +0200, Roger Pau Monné wrote: > On Thu, May 24, 2018 at 05:05:18PM +0100, Wei Liu wrote: > > This is a step towards consolidating relevant data structures and > > defines to one location. > > > > It then requires defining cpuid_leaf in user space harness headers

Re: [Xen-devel] [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h

2018-05-25 Thread Roger Pau Monné
On Thu, May 24, 2018 at 05:05:18PM +0100, Wei Liu wrote: > This is a step towards consolidating relevant data structures and > defines to one location. > > It then requires defining cpuid_leaf in user space harness headers to > make them continue to compile. > > No functional change. > >

[Xen-devel] [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h

2018-05-24 Thread Wei Liu
This is a step towards consolidating relevant data structures and defines to one location. It then requires defining cpuid_leaf in user space harness headers to make them continue to compile. No functional change. Signed-off-by: Wei Liu --- Cc: Jan Beulich