Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-15 Thread Stefano Stabellini
On Wed, 14 Nov 2018, Julien Grall wrote: > Hi, > > On 14/11/2018 22:18, Stefano Stabellini wrote: > > On Wed, 14 Nov 2018, Julien Grall wrote: > >   @@ -1319,6 +1341,129 @@ static void gicv2_do_LPI(unsigned int lpi) > >   BUG(); > >   } > >   +static void

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-14 Thread Julien Grall
Hi, On 14/11/2018 22:18, Stefano Stabellini wrote: > On Wed, 14 Nov 2018, Julien Grall wrote: >   @@ -1319,6 +1341,129 @@ static void gicv2_do_LPI(unsigned int lpi) >   BUG(); >   } >   +static void gicv2_alloc_context(struct gicv2_context *gc) > +{ Is it

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-14 Thread Stefano Stabellini
On Wed, 14 Nov 2018, Julien Grall wrote: > > > >   @@ -1319,6 +1341,129 @@ static void gicv2_do_LPI(unsigned int lpi) > > > >   BUG(); > > > >   } > > > >   +static void gicv2_alloc_context(struct gicv2_context *gc) > > > > +{ > > > > > > Is it necessary to allocate them at boot? Can we make

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-14 Thread Julien Grall
Hi Mirela, On 14/11/2018 12:52, Mirela Simonovic wrote: Thanks for the review On 11/14/2018 01:41 PM, Julien Grall wrote: Hi, I am not entirely sure where to ask it, so I will do it here. From my understanding of the PSCI spec, all the interrupts should have been migrated away from turned

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-14 Thread Mirela Simonovic
Thanks for the review On 11/14/2018 01:41 PM, Julien Grall wrote: Hi, I am not entirely sure where to ask it, so I will do it here. From my understanding of the PSCI spec, all the interrupts should have been migrated away from turned off CPU. Where do you ensure that in the suspend path?

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-14 Thread Julien Grall
Hi, I am not entirely sure where to ask it, so I will do it here. From my understanding of the PSCI spec, all the interrupts should have been migrated away from turned off CPU. Where do you ensure that in the suspend path? On 12/11/2018 11:30, Mirela Simonovic wrote: System suspend may

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-14 Thread Mirela Simonovic
On Wed, Nov 14, 2018 at 10:13 AM Julien Grall wrote: > > Hi Stefano, > > On 11/13/18 11:41 PM, Stefano Stabellini wrote: > > On Mon, 12 Nov 2018, Mirela Simonovic wrote: > >> System suspend may lead to a state where GIC would be powered down. > >> Therefore, Xen should save/restore the context of

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-14 Thread Julien Grall
Hi Stefano, On 11/13/18 11:41 PM, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Mirela Simonovic wrote: System suspend may lead to a state where GIC would be powered down. Therefore, Xen should save/restore the context of GIC on suspend/resume. Note that the context consists of states of

Re: [Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-13 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Mirela Simonovic wrote: > System suspend may lead to a state where GIC would be powered down. > Therefore, Xen should save/restore the context of GIC on suspend/resume. > Note that the context consists of states of registers which are > controlled by the hypervisor. Other GIC

[Xen-devel] [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only)

2018-11-12 Thread Mirela Simonovic
System suspend may lead to a state where GIC would be powered down. Therefore, Xen should save/restore the context of GIC on suspend/resume. Note that the context consists of states of registers which are controlled by the hypervisor. Other GIC registers which are accessible by guests are