Re: [Xen-devel] [PATCH 12/34] x86/pt: only call some functions for HVM guests

2018-08-22 Thread Wei Liu
On Mon, Aug 20, 2018 at 06:48:58AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > According to your earlier patch, has_vlapic() implies is_hvm_domain(), > so if anything is to be moved to the caller, then has_vlapic() (and > is_hvm_domain() would then to be dropped altogether).

Re: [Xen-devel] [PATCH 12/34] x86/pt: only call some functions for HVM guests

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: For the subject, do you perhaps mean "call some functions for HVM guests only"? Otherwise, putting emphasis on "some", the sense gets sort of inverted from what I think you mean. > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -561,7 +561,9

[Xen-devel] [PATCH 12/34] x86/pt: only call some functions for HVM guests

2018-08-17 Thread Wei Liu
This patch effectively lifts the check out from these functions to its caller. Asserts are added for safety. Signed-off-by: Wei Liu --- xen/arch/x86/hvm/vmsi.c | 4 +++- xen/arch/x86/hvm/vmx/vmx.c | 8 ++-- xen/drivers/passthrough/pci.c | 2 +-