Re: [Xen-devel] [PATCH 2/2] Revert "tools/libxc: disable x2APIC when using nested virtualization"

[Wei Liu]

On Wed, Jan 08, 2020 at 11:38:57AM +0100, Roger Pau Monne wrote:
> This reverts commit 7b3c5b70a32303b46d0d051e695f18d72cce5ed0 and
> re-enables the usage of x2APIC with nested virtualization.
> 
> Signed-off-by: Roger Pau Monné 

Acked-by: Wei Liu 

(subject to acceptance of patch 1, of course)

> ---
>  tools/libxc/xc_cpuid_x86.c | 11 ---
>  1 file changed, 11 deletions(-)
> 
> diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
> index ac38c1406e..2540aa1e1c 100644
> --- a/tools/libxc/xc_cpuid_x86.c
> +++ b/tools/libxc/xc_cpuid_x86.c
> @@ -653,17 +653,6 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t 
> domid,
>  p->extd.itsc = true;
>  p->basic.vmx = true;
>  p->extd.svm = true;
> -
> -/*
> - * BODGE: don't announce x2APIC mode when using nested 
> virtualization,
> - * as it doesn't work properly. This should be removed once the
> - * underlying bug(s) are fixed.
> - */
> -rc = xc_hvm_param_get(xch, domid, HVM_PARAM_NESTEDHVM, );
> -if ( rc )
> -goto out;
> -if ( val )
> -p->basic.x2apic = false;
>  }
>  
>  rc = x86_cpuid_copy_to_buffer(p, leaves, _leaves);
> -- 
> 2.24.1
> 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 2/2] Revert "tools/libxc: disable x2APIC when using nested virtualization"

[Roger Pau Monne]

This reverts commit 7b3c5b70a32303b46d0d051e695f18d72cce5ed0 and
re-enables the usage of x2APIC with nested virtualization.

Signed-off-by: Roger Pau Monné 
---
 tools/libxc/xc_cpuid_x86.c | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
index ac38c1406e..2540aa1e1c 100644
--- a/tools/libxc/xc_cpuid_x86.c
+++ b/tools/libxc/xc_cpuid_x86.c
@@ -653,17 +653,6 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t 
domid,
 p->extd.itsc = true;
 p->basic.vmx = true;
 p->extd.svm = true;
-
-/*
- * BODGE: don't announce x2APIC mode when using nested virtualization,
- * as it doesn't work properly. This should be removed once the
- * underlying bug(s) are fixed.
- */
-rc = xc_hvm_param_get(xch, domid, HVM_PARAM_NESTEDHVM, );
-if ( rc )
-goto out;
-if ( val )
-p->basic.x2apic = false;
 }
 
 rc = x86_cpuid_copy_to_buffer(p, leaves, _leaves);
-- 
2.24.1


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel