Re: [Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-12 Thread Jan Beulich
>>> On 09.11.18 at 17:24, wrote: > On 06/11/18 13:44, Jan Beulich wrote: > On 05.11.18 at 12:21, wrote: >>> --- a/xen/include/xen/lib/x86/cpuid.h >>> +++ b/xen/include/xen/lib/x86/cpuid.h >>> @@ -20,6 +20,21 @@ struct cpuid_leaf >>> uint32_t a, b, c, d; >>> }; >>> >>> +static inline

Re: [Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-09 Thread Andrew Cooper
On 06/11/18 16:31, Roger Pau Monné wrote: > On Mon, Nov 05, 2018 at 11:21:03AM +, Andrew Cooper wrote: >> This will shortly be wanted by the userspace emulator harnesses as well. >> >> Consolidate the cpuid{,_count}_leaf() helpers beside the structure >> definition, >> rather than having them

[Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-09 Thread Andrew Cooper
On 06/11/18 13:44, Jan Beulich wrote: On 05.11.18 at 12:21, wrote: >> --- a/xen/include/xen/lib/x86/cpuid.h >> +++ b/xen/include/xen/lib/x86/cpuid.h >> @@ -20,6 +20,21 @@ struct cpuid_leaf >> uint32_t a, b, c, d; >> }; >> >> +static inline void cpuid_leaf(uint32_t leaf, struct

Re: [Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-06 Thread Roger Pau Monné
On Mon, Nov 05, 2018 at 11:21:03AM +, Andrew Cooper wrote: > This will shortly be wanted by the userspace emulator harnesses as well. > > Consolidate the cpuid{,_count}_leaf() helpers beside the structure definition, > rather than having them scattered throughout Xen. > > Signed-off-by:

Re: [Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-06 Thread Jan Beulich
>>> On 05.11.18 at 12:21, wrote: > --- a/xen/include/xen/lib/x86/cpuid.h > +++ b/xen/include/xen/lib/x86/cpuid.h > @@ -20,6 +20,21 @@ struct cpuid_leaf > uint32_t a, b, c, d; > }; > > +static inline void cpuid_leaf(uint32_t leaf, struct cpuid_leaf *l) > +{ > +asm volatile ( "cpuid" >

[Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-05 Thread Andrew Cooper
This will shortly be wanted by the userspace emulator harnesses as well. Consolidate the cpuid{,_count}_leaf() helpers beside the structure definition, rather than having them scattered throughout Xen. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/arch/x86/cpuid.c