Re: [Xen-devel] [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users

2018-02-21 Thread Konrad Rzeszutek Wilk
On Mon, Feb 12, 2018 at 11:23:02AM +, Andrew Cooper wrote: > * Rename some fields for consistency and clarity, and use standard types. > * Don't opencode the use of ALT_{ORIG,REPL}_PTR(). > > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan

Re: [Xen-devel] [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users

2018-02-13 Thread Jan Beulich
>>> On 12.02.18 at 12:23, wrote: > * Rename some fields for consistency and clarity, and use standard types. > * Don't opencode the use of ALT_{ORIG,REPL}_PTR(). > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan

Re: [Xen-devel] [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users

2018-02-12 Thread Andrew Cooper
On 12/02/18 17:18, Wei Liu wrote: > On Mon, Feb 12, 2018 at 04:52:21PM +, Roger Pau Monné wrote: >> On Mon, Feb 12, 2018 at 11:23:02AM +, Andrew Cooper wrote: >>> * Rename some fields for consistency and clarity, and use standard types. >>> * Don't opencode the use of

Re: [Xen-devel] [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users

2018-02-12 Thread Wei Liu
On Mon, Feb 12, 2018 at 04:52:21PM +, Roger Pau Monné wrote: > On Mon, Feb 12, 2018 at 11:23:02AM +, Andrew Cooper wrote: > > * Rename some fields for consistency and clarity, and use standard types. > > * Don't opencode the use of ALT_{ORIG,REPL}_PTR(). > > > > No functional change. >

Re: [Xen-devel] [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users

2018-02-12 Thread Roger Pau Monné
On Mon, Feb 12, 2018 at 11:23:02AM +, Andrew Cooper wrote: > * Rename some fields for consistency and clarity, and use standard types. > * Don't opencode the use of ALT_{ORIG,REPL}_PTR(). > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by:

Re: [Xen-devel] [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users

2018-02-12 Thread Wei Liu
On Mon, Feb 12, 2018 at 11:23:02AM +, Andrew Cooper wrote: > * Rename some fields for consistency and clarity, and use standard types. > * Don't opencode the use of ALT_{ORIG,REPL}_PTR(). And change u8 etc. > > No functional change. > > Signed-off-by: Andrew Cooper

[Xen-devel] [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users

2018-02-12 Thread Andrew Cooper
* Rename some fields for consistency and clarity, and use standard types. * Don't opencode the use of ALT_{ORIG,REPL}_PTR(). No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Konrad Rzeszutek Wilk