Re: [Xen-devel] [PATCH 3/3] page-alloc: Clamp get_free_buddy() to online nodes

2019-06-25 Thread Andrew Cooper
On 25/06/2019 16:51, Jan Beulich wrote: On 25.06.19 at 16:43, wrote: >> d->node_affinity defaults to NODE_MASK_ALL which has bits set outside of >> node_online_map. This in turn causes the loop in get_free_buddy() to waste >> effort iterating over offline nodes. >> >> Always clamp

Re: [Xen-devel] [PATCH 3/3] page-alloc: Clamp get_free_buddy() to online nodes

2019-06-25 Thread Jan Beulich
>>> On 25.06.19 at 16:43, wrote: > d->node_affinity defaults to NODE_MASK_ALL which has bits set outside of > node_online_map. This in turn causes the loop in get_free_buddy() to waste > effort iterating over offline nodes. > > Always clamp d->node_affinity to node_online_map when in use. > >

[Xen-devel] [PATCH 3/3] page-alloc: Clamp get_free_buddy() to online nodes

2019-06-25 Thread Andrew Cooper
d->node_affinity defaults to NODE_MASK_ALL which has bits set outside of node_online_map. This in turn causes the loop in get_free_buddy() to waste effort iterating over offline nodes. Always clamp d->node_affinity to node_online_map when in use. Signed-off-by: Andrew Cooper --- CC: Jan