Re: [Xen-devel] [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise()

2018-03-16 Thread Jan Beulich
>>> On 15.03.18 at 21:09, wrote: > On 13/03/18 12:05, Roger Pau Monné wrote: >> Maybe this could be: >> >> if ( is_idle_domain(d) ) >> ... >> else >> { >> rc = is_hvm_domain(d) ? hvm_domain_initialise(d) >> : pv_domain_initialise(d); >>

Re: [Xen-devel] [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise()

2018-03-15 Thread Andrew Cooper
On 13/03/18 12:05, Roger Pau Monné wrote: > Maybe this could be: > > if ( is_idle_domain(d) ) > ... > else > { > rc = is_hvm_domain(d) ? hvm_domain_initialise(d) > : pv_domain_initialise(d); > if ( rc ) > goto fail; > } > > But that's maybe out of the

Re: [Xen-devel] [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise()

2018-03-13 Thread Roger Pau Monné
On Fri, Mar 09, 2018 at 01:18:39PM +, Andrew Cooper wrote: > Neither domcr_flags nor config are used on either side. Drop them, making > {hvm,pv}_domain_initialise() symmetric with all the other domain/vcpu > initialise/destroy calls. > > Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise()

2018-03-09 Thread Jan Beulich
>>> On 09.03.18 at 15:13, wrote: > On Fri, Mar 09, 2018 at 01:18:39PM +, Andrew Cooper wrote: >> Neither domcr_flags nor config are used on either side. Drop them, making >> {hvm,pv}_domain_initialise() symmetric with all the other domain/vcpu >> initialise/destroy

Re: [Xen-devel] [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise()

2018-03-09 Thread Wei Liu
On Fri, Mar 09, 2018 at 01:18:39PM +, Andrew Cooper wrote: > Neither domcr_flags nor config are used on either side. Drop them, making > {hvm,pv}_domain_initialise() symmetric with all the other domain/vcpu > initialise/destroy calls. > > Signed-off-by: Andrew Cooper

[Xen-devel] [PATCH 4/7] x86/domain: Remove unused parameters from {hvm, pv}_domain_initialise()

2018-03-09 Thread Andrew Cooper
Neither domcr_flags nor config are used on either side. Drop them, making {hvm,pv}_domain_initialise() symmetric with all the other domain/vcpu initialise/destroy calls. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu