Re: [Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, August 30, 2018 11:47 PM > > On 30/08/18 15:54, Jan Beulich wrote: > On 28.08.18 at 19:39, wrote: > >> The suffix and prefix are redundant, and the name is curiously odd. > Rename it > >> to vmx_vcpu to be consistent

Re: [Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-30 Thread Andrew Cooper
On 30/08/18 15:54, Jan Beulich wrote: On 28.08.18 at 19:39, wrote: >> The suffix and prefix are redundant, and the name is curiously odd. Rename >> it >> to vmx_vcpu to be consistent with all the other similar structures. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper >>

Re: [Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-30 Thread Jan Beulich
>>> On 28.08.18 at 19:39, wrote: > The suffix and prefix are redundant, and the name is curiously odd. Rename it > to vmx_vcpu to be consistent with all the other similar structures. > > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu > CC: Roger

Re: [Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-29 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Wednesday, August 29, 2018 1:39 AM > > The suffix and prefix are redundant, and the name is curiously odd. > Rename it > to vmx_vcpu to be consistent with all the other similar structures. > > No functional change. > >

Re: [Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-29 Thread Wei Liu
On Wed, Aug 29, 2018 at 12:17:46PM +0100, Andrew Cooper wrote: > On 29/08/18 09:03, Wei Liu wrote: > > On Tue, Aug 28, 2018 at 06:39:04PM +0100, Andrew Cooper wrote: > >> The suffix and prefix are redundant, and the name is curiously odd. > >> Rename it > >> to vmx_vcpu to be consistent with all

Re: [Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-29 Thread Andrew Cooper
On 29/08/18 09:03, Wei Liu wrote: > On Tue, Aug 28, 2018 at 06:39:04PM +0100, Andrew Cooper wrote: >> The suffix and prefix are redundant, and the name is curiously odd. Rename >> it >> to vmx_vcpu to be consistent with all the other similar structures. > What other similar structures do you

Re: [Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-29 Thread Wei Liu
On Tue, Aug 28, 2018 at 06:39:04PM +0100, Andrew Cooper wrote: > The suffix and prefix are redundant, and the name is curiously odd. Rename it > to vmx_vcpu to be consistent with all the other similar structures. What other similar structures do you have in mind? The code changes look okay to

[Xen-devel] [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu

2018-08-28 Thread Andrew Cooper
The suffix and prefix are redundant, and the name is curiously odd. Rename it to vmx_vcpu to be consistent with all the other similar structures. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Jun Nakajima CC: Kevin Tian Some of