Re: [Xen-devel] [PATCH for-4.12 v2 2/7] amd/npt/shadow: replace assert that prevents creating 2M/1G MMIO entries

2019-02-14 Thread Jan Beulich
>>> On 14.02.19 at 14:59, wrote: > On Wed, Feb 13, 2019 at 08:53:14AM -0700, Jan Beulich wrote: >> >>> On 11.02.19 at 18:46, wrote: >> > The assert was originally added to make sure that higher order >> > regions (> PAGE_ORDER_4K) could not be used to bypass the >> > mmio_ro_ranges check

Re: [Xen-devel] [PATCH for-4.12 v2 2/7] amd/npt/shadow: replace assert that prevents creating 2M/1G MMIO entries

2019-02-14 Thread Roger Pau Monné
On Wed, Feb 13, 2019 at 08:53:14AM -0700, Jan Beulich wrote: > >>> On 11.02.19 at 18:46, wrote: > > The assert was originally added to make sure that higher order > > regions (> PAGE_ORDER_4K) could not be used to bypass the > > mmio_ro_ranges check performed by p2m_type_to_flags. > > > > This

Re: [Xen-devel] [PATCH for-4.12 v2 2/7] amd/npt/shadow: replace assert that prevents creating 2M/1G MMIO entries

2019-02-13 Thread Jan Beulich
>>> On 11.02.19 at 18:46, wrote: > The assert was originally added to make sure that higher order > regions (> PAGE_ORDER_4K) could not be used to bypass the > mmio_ro_ranges check performed by p2m_type_to_flags. > > This however is already checked in set_mmio_p2m_entry, which makes > sure that

[Xen-devel] [PATCH for-4.12 v2 2/7] amd/npt/shadow: replace assert that prevents creating 2M/1G MMIO entries

2019-02-11 Thread Roger Pau Monne
The assert was originally added to make sure that higher order regions (> PAGE_ORDER_4K) could not be used to bypass the mmio_ro_ranges check performed by p2m_type_to_flags. This however is already checked in set_mmio_p2m_entry, which makes sure that higher order mappings don't overlap with