Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Michał Kowalczyk
On 8/19/19 7:28 PM, Andrew Cooper wrote: > On 19/08/2019 14:56, Michał Kowalczyk wrote: >> On 8/19/19 3:52 PM, Andrew Cooper wrote: >>> On 19/08/2019 14:50, Michał Kowalczyk wrote: On 8/19/19 11:04 AM, Andrew Cooper wrote: > On 19/08/2019 03:23, Michał Kowalczyk wrote: >> diff --git

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Andrew Cooper
On 19/08/2019 14:56, Michał Kowalczyk wrote: > On 8/19/19 3:52 PM, Andrew Cooper wrote: >> On 19/08/2019 14:50, Michał Kowalczyk wrote: >>> On 8/19/19 11:04 AM, Andrew Cooper wrote: On 19/08/2019 03:23, Michał Kowalczyk wrote: > diff --git a/xen/arch/x86/boot/trampoline.S >

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Michał Kowalczyk
On 8/19/19 3:52 PM, Andrew Cooper wrote: > On 19/08/2019 14:50, Michał Kowalczyk wrote: >> On 8/19/19 11:04 AM, Andrew Cooper wrote: >>> On 19/08/2019 03:23, Michał Kowalczyk wrote: diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S index

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Andrew Cooper
On 19/08/2019 14:50, Michał Kowalczyk wrote: > On 8/19/19 11:04 AM, Andrew Cooper wrote: >> On 19/08/2019 03:23, Michał Kowalczyk wrote: >>> diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S >>> index 7c6a2328d2..fcaa3eeaf1 100644 >>> --- a/xen/arch/x86/boot/trampoline.S

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Michał Kowalczyk
On 8/19/19 11:04 AM, Andrew Cooper wrote: > On 19/08/2019 03:23, Michał Kowalczyk wrote: >> diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S >> index 7c6a2328d2..fcaa3eeaf1 100644 >> --- a/xen/arch/x86/boot/trampoline.S >> +++ b/xen/arch/x86/boot/trampoline.S >> @@

Re: [Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-19 Thread Andrew Cooper
On 19/08/2019 03:23, Michał Kowalczyk wrote: > diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S > index 7c6a2328d2..fcaa3eeaf1 100644 > --- a/xen/arch/x86/boot/trampoline.S > +++ b/xen/arch/x86/boot/trampoline.S > @@ -85,7 +85,7 @@ trampoline_gdt: > .long

[Xen-devel] [PATCH v1] x86: Restore IA32_MISC_ENABLE on wakeup

2019-08-18 Thread Michał Kowalczyk
Code in intel.c:early_init_intel() modifies IA32_MISC_ENABLE MSR. Those modifications must be restored after resuming from S3 (see e.g. Linux wakeup code), otherwise bad things may happen (e.g. wakeup code may cause #GP when trying to set IA32_EFER.NXE [1]). This bug was noticed on a ThinkPad