Re: [Xen-devel] [PATCH v1] xen_disk: fix memory leak

2018-12-13 Thread Paul Durrant
..@nongnu.org; Max Reitz ; > open list:X86 > Subject: Re: [Xen-devel] [PATCH v1] xen_disk: fix memory leak > > On Tue, Dec 11, 2018 at 05:02:24PM +0100, Olaf Hering wrote: > > There are some code paths that clobber ioreq->buf, which leads to a huge > > memo

Re: [Xen-devel] [PATCH v1] xen_disk: fix memory leak

2018-12-13 Thread Anthony PERARD
On Tue, Dec 11, 2018 at 05:02:24PM +0100, Olaf Hering wrote: > There are some code paths that clobber ioreq->buf, which leads to a huge > memory leak after a few hours of runtime. One code path is > qemu_aio_complete, which might be called recursive. Another one is I think it's

[Xen-devel] [PATCH v1] xen_disk: fix memory leak

2018-12-11 Thread Olaf Hering
There are some code paths that clobber ioreq->buf, which leads to a huge memory leak after a few hours of runtime. One code path is qemu_aio_complete, which might be called recursive. Another one is ioreq_reset, which might clobber ioreq->buf as well. Add wrappers to free ioreq->buf before