Re: [Xen-devel] [PATCH v2] xen/blkfront: avoid NULL blkfront_info dereference on device removal

2018-10-18 Thread Konrad Rzeszutek Wilk
On Mon, Oct 15, 2018 at 04:25:56PM +0200, Vasilis Liaskovitis wrote: > On Mon, 2018-10-15 at 16:02 +0200, Roger Pau Monné wrote: > > > > > This results in a NULL pointer BUG when blkfront_remove and > > > blkif_free > > > try to access the failing device's NULL struct blkfront_info. > > > > > >

Re: [Xen-devel] [PATCH v2] xen/blkfront: avoid NULL blkfront_info dereference on device removal

2018-10-15 Thread Roger Pau Monné
On Mon, Oct 15, 2018 at 03:25:08PM +0200, Vasilis Liaskovitis wrote: > If a block device is hot-added when we are out of grants, > gnttab_grant_foreign_access fails with -ENOSPC (log message "28 > granting access to ring page") in this code path: > > talk_to_blkback -> > setup_blkring ->

[Xen-devel] [PATCH v2] xen/blkfront: avoid NULL blkfront_info dereference on device removal

2018-10-15 Thread Vasilis Liaskovitis
If a block device is hot-added when we are out of grants, gnttab_grant_foreign_access fails with -ENOSPC (log message "28 granting access to ring page") in this code path: talk_to_blkback -> setup_blkring -> xenbus_grant_ring ->