Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Juergen Gross
On 12.09.19 14:08, Jan Beulich wrote: On 12.09.2019 13:53, Juergen Gross wrote: On 12.09.19 13:46, Jan Beulich wrote: On 12.09.2019 13:17, Juergen Gross wrote: On 12.09.19 12:04, Jan Beulich wrote: On 12.09.2019 11:34, Juergen Gross wrote: Okayy, I'll rename "cpu" to "my_cpu". We've got a

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Jan Beulich
On 12.09.2019 13:53, Juergen Gross wrote: > On 12.09.19 13:46, Jan Beulich wrote: >> On 12.09.2019 13:17, Juergen Gross wrote: >>> On 12.09.19 12:04, Jan Beulich wrote: On 12.09.2019 11:34, Juergen Gross wrote: > Okayy, I'll rename "cpu" to "my_cpu". We've got a number of

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Juergen Gross
On 12.09.19 13:46, Jan Beulich wrote: On 12.09.2019 13:17, Juergen Gross wrote: On 12.09.19 12:04, Jan Beulich wrote: On 12.09.2019 11:34, Juergen Gross wrote: On 09.09.19 16:17, Jan Beulich wrote: On 09.08.2019 16:58, Juergen Gross wrote: @@ -1825,8 +1825,9 @@ static struct task_slice

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Jan Beulich
On 12.09.2019 13:17, Juergen Gross wrote: > On 12.09.19 12:04, Jan Beulich wrote: >> On 12.09.2019 11:34, Juergen Gross wrote: >>> On 09.09.19 16:17, Jan Beulich wrote: On 09.08.2019 16:58, Juergen Gross wrote: > @@ -1825,8 +1825,9 @@ static struct task_slice >csched_schedule(

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Juergen Gross
On 12.09.19 12:04, Jan Beulich wrote: On 12.09.2019 11:34, Juergen Gross wrote: On 09.09.19 16:17, Jan Beulich wrote: On 09.08.2019 16:58, Juergen Gross wrote: @@ -1825,8 +1825,9 @@ static struct task_slice csched_schedule( const struct scheduler *ops, s_time_t now, bool_t

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Juergen Gross
On 12.09.19 12:04, Jan Beulich wrote: On 12.09.2019 11:34, Juergen Gross wrote: On 09.09.19 16:17, Jan Beulich wrote: On 09.08.2019 16:58, Juergen Gross wrote: @@ -1825,8 +1825,9 @@ static struct task_slice csched_schedule( const struct scheduler *ops, s_time_t now, bool_t

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Jan Beulich
On 12.09.2019 11:34, Juergen Gross wrote: > On 09.09.19 16:17, Jan Beulich wrote: >> On 09.08.2019 16:58, Juergen Gross wrote: >>> @@ -1825,8 +1825,9 @@ static struct task_slice >>> csched_schedule( >>> const struct scheduler *ops, s_time_t now, bool_t >>> tasklet_work_scheduled) >>> {

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-12 Thread Juergen Gross
On 09.09.19 16:17, Jan Beulich wrote: On 09.08.2019 16:58, Juergen Gross wrote: Especially in the do_schedule() functions of the different schedulers using smp_processor_id() for the local cpu number is correct only if the sched_unit is a single vcpu. As soon as larger sched_units are used most

Re: [Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-09-09 Thread Jan Beulich
On 09.08.2019 16:58, Juergen Gross wrote: > Especially in the do_schedule() functions of the different schedulers > using smp_processor_id() for the local cpu number is correct only if > the sched_unit is a single vcpu. As soon as larger sched_units are > used most uses should be replaced by the

[Xen-devel] [PATCH v2 21/48] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers

2019-08-09 Thread Juergen Gross
Especially in the do_schedule() functions of the different schedulers using smp_processor_id() for the local cpu number is correct only if the sched_unit is a single vcpu. As soon as larger sched_units are used most uses should be replaced by the cpu number of the local sched_resource instead.