Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-09 Thread Jan Beulich
On 08.07.2019 21:27, Julien Grall wrote: > Hi, > > On 7/8/19 7:11 PM, Andrew Cooper wrote: >> On 07/07/2019 19:42, Julien Grall wrote: >>> Hi Andrew, >>> >>> On 7/4/19 8:14 PM, Andrew Cooper wrote: To allow for further improvements, it is useful to be able to clear more than a

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-08 Thread Julien Grall
Hi Andrew, On 7/8/19 9:38 PM, Andrew Cooper wrote: On 08/07/2019 21:28, Julien Grall wrote: https://lore.kernel.org/xen-devel/1561109798-8744-5-git-send-email-andrew.coop...@citrix.com/T/#t To be honest, I think it is wrong to try to micro-optimize a common prototype for the benefit of

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-08 Thread Andrew Cooper
On 08/07/2019 21:28, Julien Grall wrote: https://lore.kernel.org/xen-devel/1561109798-8744-5-git-send-email-andrew.coop...@citrix.com/T/#t >>> >>> To be honest, I think it is wrong to try to micro-optimize a common >>> prototype for the benefit of one architecture and one

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-08 Thread Julien Grall
Hi Andrew, On 7/8/19 9:21 PM, Andrew Cooper wrote: On 08/07/2019 20:27, Julien Grall wrote: Hi, On 7/8/19 7:11 PM, Andrew Cooper wrote: On 07/07/2019 19:42, Julien Grall wrote: Hi Andrew, On 7/4/19 8:14 PM, Andrew Cooper wrote: To allow for further improvements, it is useful to be able to

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-08 Thread Andrew Cooper
On 08/07/2019 20:27, Julien Grall wrote: > Hi, > > On 7/8/19 7:11 PM, Andrew Cooper wrote: >> On 07/07/2019 19:42, Julien Grall wrote: >>> Hi Andrew, >>> >>> On 7/4/19 8:14 PM, Andrew Cooper wrote: To allow for further improvements, it is useful to be able to clear more than a

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-08 Thread Julien Grall
Hi, On 7/8/19 7:11 PM, Andrew Cooper wrote: On 07/07/2019 19:42, Julien Grall wrote: Hi Andrew, On 7/4/19 8:14 PM, Andrew Cooper wrote: To allow for further improvements, it is useful to be able to clear more than a single flag at once.  Rework gnttab_clear_flag() into gnttab_clear_flags()

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-08 Thread Andrew Cooper
On 07/07/2019 19:42, Julien Grall wrote: > Hi Andrew, > > On 7/4/19 8:14 PM, Andrew Cooper wrote: >> To allow for further improvements, it is useful to be able to clear >> more than >> a single flag at once.  Rework gnttab_clear_flag() into >> gnttab_clear_flags() >> which takes a bitmask rather

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-08 Thread Julien Grall
Hi Andrew, On 7/4/19 8:14 PM, Andrew Cooper wrote: To allow for further improvements, it is useful to be able to clear more than a single flag at once. Rework gnttab_clear_flag() into gnttab_clear_flags() which takes a bitmask rather than a bit number. No practical change yet. Signed-off-by:

Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-05 Thread Jan Beulich
On 04.07.2019 21:14, Andrew Cooper wrote: > To allow for further improvements, it is useful to be able to clear more than > a single flag at once. Rework gnttab_clear_flag() into gnttab_clear_flags() > which takes a bitmask rather than a bit number. > > No practical change yet. > >

[Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()

2019-07-04 Thread Andrew Cooper
To allow for further improvements, it is useful to be able to clear more than a single flag at once. Rework gnttab_clear_flag() into gnttab_clear_flags() which takes a bitmask rather than a bit number. No practical change yet. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: