Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 16:46, wrote: > On Tue, Oct 30, 2018 at 09:40:17AM -0600, Jan Beulich wrote: >> >>> On 30.10.18 at 16:32, wrote: >> > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: >> >> >>> On 22.10.18 at 14:58, wrote: >> >> > --- a/xen/common/efi/boot.c >> >> > +++

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 09:40:17AM -0600, Jan Beulich wrote: > >>> On 30.10.18 at 16:32, wrote: > > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: > >> >>> On 22.10.18 at 14:58, wrote: > >> > --- a/xen/common/efi/boot.c > >> > +++ b/xen/common/efi/boot.c > >> > @@ -487,6 +487,7 @@

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 16:32, wrote: > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: >> >>> On 22.10.18 at 14:58, wrote: >> > --- a/xen/common/efi/boot.c >> > +++ b/xen/common/efi/boot.c >> > @@ -487,6 +487,7 @@ static EFI_FILE_HANDLE __init >> > get_parent_handle(EFI_LOADED_IMAGE

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Mon, Oct 22, 2018 at 01:58:02PM +0100, Andrew Cooper wrote: > With almost all users of keyhandler_scratch gone, clean up the 3 remaining > users and drop the buffer. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: > >>> On 22.10.18 at 14:58, wrote: > > --- a/xen/common/efi/boot.c > > +++ b/xen/common/efi/boot.c > > @@ -487,6 +487,7 @@ static EFI_FILE_HANDLE __init > > get_parent_handle(EFI_LOADED_IMAGE *loaded_image, > >

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-26 Thread Jan Beulich
>>> On 22.10.18 at 14:58, wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -487,6 +487,7 @@ static EFI_FILE_HANDLE __init > get_parent_handle(EFI_LOADED_IMAGE *loaded_image, > CHAR16 **leaf) > { > static EFI_GUID

[Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-22 Thread Andrew Cooper
With almost all users of keyhandler_scratch gone, clean up the 3 remaining users and drop the buffer. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné v2: * Use a static __initdata buffer for EFI, rather than a stack variable. * Drop (int) casts for periodic