On 13/06/18 07:30, Jan Beulich wrote:
On 12.06.18 at 18:33, wrote:
>> On 12/06/18 10:00, Jan Beulich wrote:
>> On 12.06.18 at 10:51, wrote:
On 12/06/2018 09:15, Jan Beulich wrote:
On 08.06.18 at 20:48, wrote:
>> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercep
>>> On 12.06.18 at 18:33, wrote:
> On 12/06/18 10:00, Jan Beulich wrote:
> On 12.06.18 at 10:51, wrote:
>>> On 12/06/2018 09:15, Jan Beulich wrote:
>>> On 08.06.18 at 20:48, wrote:
> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int
> msr,
>
>>> uint64_t
On 12/06/18 10:00, Jan Beulich wrote:
On 12.06.18 at 10:51, wrote:
>> On 12/06/2018 09:15, Jan Beulich wrote:
>> On 08.06.18 at 20:48, wrote:
@@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int
msr,
>> uint64_t msr_content)
for ( ; (rc ==
>>> On 12.06.18 at 10:51, wrote:
> On 12/06/2018 09:15, Jan Beulich wrote:
> On 08.06.18 at 20:48, wrote:
>>> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int
>>> msr,
> uint64_t msr_content)
>>> for ( ; (rc == 0) && lbr->count; lbr++ )
>>>
On 12/06/2018 09:15, Jan Beulich wrote:
On 08.06.18 at 20:48, wrote:
>> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int msr,
>> uint64_t msr_content)
>> for ( ; (rc == 0) && lbr->count; lbr++ )
>> for ( i = 0; (rc == 0) && (i < lbr->count
>>> On 08.06.18 at 20:48, wrote:
> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int msr,
> uint64_t msr_content)
> for ( ; (rc == 0) && lbr->count; lbr++ )
> for ( i = 0; (rc == 0) && (i < lbr->count); i++ )
> if ( (rc = vm
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
> Sent: Saturday, June 9, 2018 2:49 AM
>
> The main purpose of this patch is to only ever insert the LBR MSRs into the
> guest load/save list once, as a future patch wants to change the behaviour
> of
> vmx_add_guest_msr().
>
> The repeated
The main purpose of this patch is to only ever insert the LBR MSRs into the
guest load/save list once, as a future patch wants to change the behaviour of
vmx_add_guest_msr().
The repeated processing of lbr_info and the guests MSR load/save list is
redundant, and a guest using LBR itself will have