Re: [Xen-devel] [PATCH v3 0/7] LLVM coverage support for Xen

[Jan Beulich]

>>> On 13.02.18 at 17:28,  wrote:
> On Tue, Feb 13, 2018 at 09:16:19AM -0700, Jan Beulich wrote:
>> >>> On 13.02.18 at 16:53,  wrote:
>> > On Wed, Jan 24, 2018 at 10:01:18AM +, Roger Pau Monne wrote:
>> >> Hello,
>> >> 
>> >> The following patch series enables LLVM coverage support for the Xen
>> >> hypervisor. A sample coverage report obtained after booting a PVHv2 Dom0
>> >> can be found at:
>> >> 
>> >> http://xenbits.xen.org/people/royger/xen_profile/ 
>> >> 
>> >> I know the time is not the most appropriate given all the security work
>> >> going on, but it seems like the series is quite close, and I would ike
>> >> to avoid it bitrotting.
>> > 
>> > Patches 5, 6 and 7 have already been reviewed/acked by the relevant
>> > maintainers, is there anything preventing them from going in?
>> 
>> I didn't keep them in my inbox when it became clear that patch 4
>> needs another version, which is why I did apply only that single
>> patch.
> 
> Oh, since patch 4 was the only one that had comments I only sent that.
> Would you like me to send or push to a git branch the remaining ones?

Normally I think it would have been best if you resent them
without asking, rather than just sending a singleton 4/7 patch.
This time, however, I've managed to fish them out of the mail
client's waste basket, and I've just committed and pushed them.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/7] LLVM coverage support for Xen

[Roger Pau Monné]

On Tue, Feb 13, 2018 at 09:16:19AM -0700, Jan Beulich wrote:
> >>> On 13.02.18 at 16:53,  wrote:
> > On Wed, Jan 24, 2018 at 10:01:18AM +, Roger Pau Monne wrote:
> >> Hello,
> >> 
> >> The following patch series enables LLVM coverage support for the Xen
> >> hypervisor. A sample coverage report obtained after booting a PVHv2 Dom0
> >> can be found at:
> >> 
> >> http://xenbits.xen.org/people/royger/xen_profile/ 
> >> 
> >> I know the time is not the most appropriate given all the security work
> >> going on, but it seems like the series is quite close, and I would ike
> >> to avoid it bitrotting.
> > 
> > Patches 5, 6 and 7 have already been reviewed/acked by the relevant
> > maintainers, is there anything preventing them from going in?
> 
> I didn't keep them in my inbox when it became clear that patch 4
> needs another version, which is why I did apply only that single
> patch.

Oh, since patch 4 was the only one that had comments I only sent that.
Would you like me to send or push to a git branch the remaining ones?

Thanks, Roger.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/7] LLVM coverage support for Xen

[Jan Beulich]

>>> On 13.02.18 at 16:53,  wrote:
> On Wed, Jan 24, 2018 at 10:01:18AM +, Roger Pau Monne wrote:
>> Hello,
>> 
>> The following patch series enables LLVM coverage support for the Xen
>> hypervisor. A sample coverage report obtained after booting a PVHv2 Dom0
>> can be found at:
>> 
>> http://xenbits.xen.org/people/royger/xen_profile/ 
>> 
>> I know the time is not the most appropriate given all the security work
>> going on, but it seems like the series is quite close, and I would ike
>> to avoid it bitrotting.
> 
> Patches 5, 6 and 7 have already been reviewed/acked by the relevant
> maintainers, is there anything preventing them from going in?

I didn't keep them in my inbox when it became clear that patch 4
needs another version, which is why I did apply only that single
patch.

Jan



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/7] LLVM coverage support for Xen

[Roger Pau Monné]

On Wed, Jan 24, 2018 at 10:01:18AM +, Roger Pau Monne wrote:
> Hello,
> 
> The following patch series enables LLVM coverage support for the Xen
> hypervisor. A sample coverage report obtained after booting a PVHv2 Dom0
> can be found at:
> 
> http://xenbits.xen.org/people/royger/xen_profile/
> 
> I know the time is not the most appropriate given all the security work
> going on, but it seems like the series is quite close, and I would ike
> to avoid it bitrotting.

Patches 5, 6 and 7 have already been reviewed/acked by the relevant
maintainers, is there anything preventing them from going in?

Thanks, Roger.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v3 0/7] LLVM coverage support for Xen

[Roger Pau Monne]

Hello,

The following patch series enables LLVM coverage support for the Xen
hypervisor. A sample coverage report obtained after booting a PVHv2 Dom0
can be found at:

http://xenbits.xen.org/people/royger/xen_profile/

I know the time is not the most appropriate given all the security work
going on, but it seems like the series is quite close, and I would ike
to avoid it bitrotting.

Thanks, Roger.

Roger Pau Monne (7):
  gcov: rename sysctl and functions
  gcov: introduce hooks for the sysctl
  coverage: introduce generic file
  kconfig/gcov: rename to coverage
  coverage: introduce support for llvm profiling
  xsm: add bodge when compiling with llvm coverage support
  coverage: add documentation for LLVM coverage

 docs/misc/coverage.markdown|  49 -
 tools/misc/xencov.c|  28 
 xen/Kconfig.debug  |   6 +-
 xen/Rules.mk   |   9 ++-
 xen/common/Makefile|   2 +-
 xen/common/coverage/Makefile   |   5 ++
 xen/common/coverage/coverage.c |  73 +++
 xen/common/coverage/coverage.h |  23 ++
 xen/common/coverage/gcov.c |  42 ++-
 xen/common/coverage/llvm.c | 154 +
 xen/common/sysctl.c|   6 +-
 xen/include/public/sysctl.h|  18 +++--
 xen/include/xen/coverage.h |   9 ++-
 xen/include/xsm/dummy.h|  14 
 14 files changed, 369 insertions(+), 69 deletions(-)
 create mode 100644 xen/common/coverage/coverage.c
 create mode 100644 xen/common/coverage/coverage.h
 create mode 100644 xen/common/coverage/llvm.c

-- 
2.15.1


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel