Re: [Xen-devel] [PATCH v3 02/14] AMD/IOMMU: use bit field for extended feature register

2019-07-19 Thread Jan Beulich
On 19.07.2019 18:23, Andrew Cooper wrote: > On 16/07/2019 17:35, Jan Beulich wrote: >> This also takes care of several of the shift values wrongly having been >> specified as hex rather than dec. >> >> Take the opportunity and >> - replace a readl() pair by a single readq(), >> - add further

Re: [Xen-devel] [PATCH v3 02/14] AMD/IOMMU: use bit field for extended feature register

2019-07-19 Thread Andrew Cooper
On 16/07/2019 17:35, Jan Beulich wrote: > This also takes care of several of the shift values wrongly having been > specified as hex rather than dec. > > Take the opportunity and > - replace a readl() pair by a single readq(), > - add further fields. > > Signed-off-by: Jan Beulich CI is happy

Re: [Xen-devel] [PATCH v3 02/14] AMD/IOMMU: use bit field for extended feature register

2019-07-17 Thread Jan Beulich
On 16.07.2019 18:35, Jan Beulich wrote: > --- a/xen/drivers/passthrough/amd/iommu_detect.c > +++ b/xen/drivers/passthrough/amd/iommu_detect.c > @@ -60,49 +60,77 @@ static int __init get_iommu_capabilities > >void __init get_iommu_features(struct amd_iommu *iommu) >{ > -u32 low,

[Xen-devel] [PATCH v3 02/14] AMD/IOMMU: use bit field for extended feature register

2019-07-16 Thread Jan Beulich
This also takes care of several of the shift values wrongly having been specified as hex rather than dec. Take the opportunity and - replace a readl() pair by a single readq(), - add further fields. Signed-off-by: Jan Beulich --- v3: Another attempt at deriving masks from bitfields, hopefully