Re: [Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-25 Thread Julien Grall
Hi Konrad, On 22/06/18 14:33, Konrad Rzeszutek Wilk wrote: On Tue, Jun 12, 2018 at 11:06:16PM +0100, Julien Grall wrote: On 12/06/2018 22:17, Konrad Rzeszutek Wilk wrote: On Tue, Jun 12, 2018 at 12:36:37PM +0100, Julien Grall wrote: Won't this mean the traps (if there are any) won't be recogni

Re: [Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-22 Thread Konrad Rzeszutek Wilk
On Tue, Jun 12, 2018 at 11:06:16PM +0100, Julien Grall wrote: > Hi Konrad, > > On 12/06/2018 22:17, Konrad Rzeszutek Wilk wrote: > > On Tue, Jun 12, 2018 at 12:36:37PM +0100, Julien Grall wrote: > > > During the MMU setup process, Xen will set SCTLR_EL2.WNX > > > (Write-Non-eXecutable) bit. Becaus

Re: [Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-12 Thread Julien Grall
Hi Konrad, On 12/06/2018 22:17, Konrad Rzeszutek Wilk wrote: On Tue, Jun 12, 2018 at 12:36:37PM +0100, Julien Grall wrote: During the MMU setup process, Xen will set SCTLR_EL2.WNX (Write-Non-eXecutable) bit. Because of that, the alternative code need to re-mapped the region in a difference plac

Re: [Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-12 Thread Konrad Rzeszutek Wilk
On Tue, Jun 12, 2018 at 12:36:37PM +0100, Julien Grall wrote: > During the MMU setup process, Xen will set SCTLR_EL2.WNX > (Write-Non-eXecutable) bit. Because of that, the alternative code need > to re-mapped the region in a difference place in order to modify the > text section. > > At the moment

[Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-12 Thread Julien Grall
During the MMU setup process, Xen will set SCTLR_EL2.WNX (Write-Non-eXecutable) bit. Because of that, the alternative code need to re-mapped the region in a difference place in order to modify the text section. At the moment, the function patching the code is only aware of the re-mapped region. Th