Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-15 Thread Christopher Clark
On Tue, Jan 15, 2019 at 12:36 AM Jan Beulich wrote: > > >>> On 15.01.19 at 08:56, wrote: > > On Mon, Jan 14, 2019 at 6:19 AM Jan Beulich wrote: > >> >>> On 07.01.19 at 08:42, wrote: > >> > +/* > >> > + * A ring must be large enough to transmit messages, so requires > >> > space for: >

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 08:56, wrote: > On Mon, Jan 14, 2019 at 6:19 AM Jan Beulich wrote: >> >>> On 07.01.19 at 08:42, wrote: >> > +/* >> > + * A ring must be large enough to transmit messages, so requires >> > space for: >> > + * * 1 message header, plus >> > + * * 1 payload slot

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-15 Thread Christopher Clark
On Mon, Jan 14, 2019 at 7:31 AM Andrew Cooper wrote: > > On 07/01/2019 07:42, Christopher Clark wrote: > > diff --git a/docs/misc/xen-command-line.pandoc > > b/docs/misc/xen-command-line.pandoc > > index aea13eb..68d4415 100644 > > --- a/docs/misc/xen-command-line.pandoc > > +++

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-14 Thread Christopher Clark
On Mon, Jan 14, 2019 at 6:19 AM Jan Beulich wrote: > > >>> On 07.01.19 at 08:42, wrote: > > --- a/xen/common/argo.c > > +++ b/xen/common/argo.c > > @@ -23,16 +23,41 @@ > > #include > > #include > > #include > > +#include > > +#include > > #include > > #include > > > > +#define

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-14 Thread Andrew Cooper
On 07/01/2019 07:42, Christopher Clark wrote: > diff --git a/docs/misc/xen-command-line.pandoc > b/docs/misc/xen-command-line.pandoc > index aea13eb..68d4415 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -193,6 +193,21 @@ This allows domains

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-14 Thread Jan Beulich
>>> On 07.01.19 at 08:42, wrote: > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -23,16 +23,41 @@ > #include > #include > #include > +#include > +#include > #include > #include > > +#define MAX_RINGS_PER_DOMAIN128U > + > +/* All messages on the ring are padded

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-11 Thread Roger Pau Monné
On Fri, Jan 11, 2019 at 7:29 AM Christopher Clark wrote: > > On Thu, Jan 10, 2019 at 3:25 AM Roger Pau Monné wrote: > > > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > wrote: > > > +static int > > > +ring_map_page(struct argo_ring_info *ring_info, unsigned int i, void > > >

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-10 Thread Christopher Clark
On Thu, Jan 10, 2019 at 3:57 AM Jan Beulich wrote: > > >>> On 10.01.19 at 12:24, wrote: > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > wrote: > >> +static long > >> +register_ring(struct domain *currd, > > > > If this is indeed the current domain (as the name suggests), why do > >

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-10 Thread Christopher Clark
On Thu, Jan 10, 2019 at 3:25 AM Roger Pau Monné wrote: > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > wrote: > > > > The register op is used by a domain to register a region of memory for > > receiving messages from either a specified other domain, or, if specifying a > > wildcard, any

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-10 Thread Christopher Clark
On Thu, Jan 10, 2019 at 12:11 PM Eric Chanudet wrote: > > On 06/01/19 at 11:42pm, Christopher Clark wrote: > >+/* > >+ * The maximum size of an Argo ring is defined to be: 16GB > >+ * -- which is 0x100 bytes. > >+ * A byte index into the ring is at most 24 bits. > >+ */ > >+#define

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-10 Thread Eric Chanudet
On 06/01/19 at 11:42pm, Christopher Clark wrote: +/* + * The maximum size of an Argo ring is defined to be: 16GB + * -- which is 0x100 bytes. + * A byte index into the ring is at most 24 bits. + */ +#define XEN_ARGO_MAX_RING_SIZE (0x100ULL) It looks like 16MB. Did I miss a <<10

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-10 Thread Jan Beulich
>>> On 10.01.19 at 12:24, wrote: > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > wrote: >> +static long >> +register_ring(struct domain *currd, > > If this is indeed the current domain (as the name suggests), why do > you need to pass it around? Or else just name the parameter d. When

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-10 Thread Roger Pau Monné
On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark wrote: > > The register op is used by a domain to register a region of memory for > receiving messages from either a specified other domain, or, if specifying a > wildcard, any domain. > > This operation creates a mapping within Xen's private

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Christopher Clark
On Wed, Jan 9, 2019 at 10:28 AM Julien Grall wrote: > > > > On Wed, 9 Jan 2019, 12:54 Wei Liu, wrote: >> >> On Wed, Jan 09, 2019 at 12:02:34PM -0500, Julien Grall wrote: >> > Hi, >> > >> > Sorry for the formatting. Sending it from my phone. >> > >> > On Wed, 9 Jan 2019, 11:03 Christopher Clark,

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Christopher Clark
On Wed, Jan 9, 2019 at 10:14 AM Julien Grall wrote: > On Wed, 9 Jan 2019, 12:18 Stefano Stabellini, wrote: >> On Wed, 9 Jan 2019, Julien Grall wrote: >> > Hi, >> > Sorry for the formatting. Sending it from my phone. >> > >> > On Wed, 9 Jan 2019, 11:03 Christopher Clark, >> > wrote: >> >

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Julien Grall
On Wed, 9 Jan 2019, 12:54 Wei Liu, wrote: > On Wed, Jan 09, 2019 at 12:02:34PM -0500, Julien Grall wrote: > > Hi, > > > > Sorry for the formatting. Sending it from my phone. > > > > On Wed, 9 Jan 2019, 11:03 Christopher Clark, < > christopher.w.cl...@gmail.com> > > wrote: > > > > > On Wed, Jan

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Julien Grall
Ki On Wed, 9 Jan 2019, 12:18 Stefano Stabellini, wrote: > On Wed, 9 Jan 2019, Julien Grall wrote: > > Hi, > > Sorry for the formatting. Sending it from my phone. > > > > On Wed, 9 Jan 2019, 11:03 Christopher Clark, < > christopher.w.cl...@gmail.com> wrote: > > On Wed, Jan 9, 2019 at 7:56

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Wei Liu
On Wed, Jan 09, 2019 at 12:02:34PM -0500, Julien Grall wrote: > Hi, > > Sorry for the formatting. Sending it from my phone. > > On Wed, 9 Jan 2019, 11:03 Christopher Clark, > wrote: > > > On Wed, Jan 9, 2019 at 7:56 AM Wei Liu wrote: > > > > > > On Sun, Jan 06, 2019 at 11:42:40PM -0800,

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Stefano Stabellini
On Wed, 9 Jan 2019, Julien Grall wrote: > Hi, > Sorry for the formatting. Sending it from my phone. > > On Wed, 9 Jan 2019, 11:03 Christopher Clark, > wrote: > On Wed, Jan 9, 2019 at 7:56 AM Wei Liu wrote: > > > > On Sun, Jan 06, 2019 at 11:42:40PM -0800, Christopher Clark

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Julien Grall
Hi, Sorry for the formatting. Sending it from my phone. On Wed, 9 Jan 2019, 11:03 Christopher Clark, wrote: > On Wed, Jan 9, 2019 at 7:56 AM Wei Liu wrote: > > > > On Sun, Jan 06, 2019 at 11:42:40PM -0800, Christopher Clark wrote: > > > The register op is used by a domain to register a region

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Christopher Clark
On Wed, Jan 9, 2019 at 7:56 AM Wei Liu wrote: > > On Sun, Jan 06, 2019 at 11:42:40PM -0800, Christopher Clark wrote: > > The register op is used by a domain to register a region of memory for > > receiving messages from either a specified other domain, or, if specifying a > > wildcard, any

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-09 Thread Wei Liu
On Sun, Jan 06, 2019 at 11:42:40PM -0800, Christopher Clark wrote: > The register op is used by a domain to register a region of memory for > receiving messages from either a specified other domain, or, if specifying a > wildcard, any domain. > > This operation creates a mapping within Xen's

[Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-06 Thread Christopher Clark
The register op is used by a domain to register a region of memory for receiving messages from either a specified other domain, or, if specifying a wildcard, any domain. This operation creates a mapping within Xen's private address space that will remain resident for the lifetime of the ring. In