Re: [Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-23 Thread Jan Beulich
On 23.07.2019 10:13, Jan Beulich wrote: > On 22.07.2019 17:43, Andrew Cooper wrote: >> How would your argument change if the IOMMU was a real CPU running real >> x86 code?  Its interface to the rest of the system would be identical, >> and in that case, it would obviously need an smp_{r,w}mb()

Re: [Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-23 Thread Jan Beulich
On 22.07.2019 17:43, Andrew Cooper wrote: > On 22/07/2019 16:01, Jan Beulich wrote: >> On 22.07.2019 15:36, Andrew Cooper wrote: >>> On 22/07/2019 09:34, Jan Beulich wrote: On 19.07.2019 19:27, Andrew Cooper wrote: > On 16/07/2019 17:38, Jan Beulich wrote: >> @@ -142,7 +178,15 @@

Re: [Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-22 Thread Andrew Cooper
On 22/07/2019 16:01, Jan Beulich wrote: > On 22.07.2019 15:36, Andrew Cooper wrote: >> On 22/07/2019 09:34, Jan Beulich wrote: >>> On 19.07.2019 19:27, Andrew Cooper wrote: On 16/07/2019 17:38, Jan Beulich wrote: > @@ -142,7 +178,15 @@ static void free_intremap_entry(const st > {

Re: [Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-22 Thread Jan Beulich
On 22.07.2019 15:36, Andrew Cooper wrote: > On 22/07/2019 09:34, Jan Beulich wrote: >> On 19.07.2019 19:27, Andrew Cooper wrote: >>> On 16/07/2019 17:38, Jan Beulich wrote: @@ -142,7 +178,15 @@ static void free_intremap_entry(const st { union irte_ptr entry =

Re: [Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-22 Thread Andrew Cooper
On 22/07/2019 09:34, Jan Beulich wrote: > On 19.07.2019 19:27, Andrew Cooper wrote: >> On 16/07/2019 17:38, Jan Beulich wrote: >>> @@ -142,7 +178,15 @@ static void free_intremap_entry(const st >>>{ >>>union irte_ptr entry = get_intremap_entry(iommu, bdf, index); >>> >>> -

Re: [Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-22 Thread Jan Beulich
On 19.07.2019 19:27, Andrew Cooper wrote: > On 16/07/2019 17:38, Jan Beulich wrote: >> This is in preparation of actually enabling x2APIC mode, which requires >> this wider IRTE format to be used. >> >> A specific remark regarding the first hunk changing >> amd_iommu_ioapic_update_ire(): This

Re: [Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-19 Thread Andrew Cooper
On 16/07/2019 17:38, Jan Beulich wrote: > This is in preparation of actually enabling x2APIC mode, which requires > this wider IRTE format to be used. > > A specific remark regarding the first hunk changing > amd_iommu_ioapic_update_ire(): This bypass was introduced for XSA-36, > i.e. by

[Xen-devel] [PATCH v3 08/14] AMD/IOMMU: introduce 128-bit IRTE non-guest-APIC IRTE format

2019-07-16 Thread Jan Beulich
This is in preparation of actually enabling x2APIC mode, which requires this wider IRTE format to be used. A specific remark regarding the first hunk changing amd_iommu_ioapic_update_ire(): This bypass was introduced for XSA-36, i.e. by 94d4a1119d ("AMD,IOMMU: Clean up old entries in remapping