Re: [Xen-devel] [PATCH v3 1/5] xen/spinlocks: in debug builds store cpu holding the lock

2019-09-03 Thread Jan Beulich
On 03.09.2019 16:31, Juergen Gross wrote: > On 03.09.19 16:11, Jan Beulich wrote: >> On 29.08.2019 12:18, Juergen Gross wrote: >>> --- a/xen/include/xen/spinlock.h >>> +++ b/xen/include/xen/spinlock.h >>> @@ -6,14 +6,21 @@ >>> #include >>> >>> #ifndef NDEBUG >>> -struct lock_debug { >>> -

Re: [Xen-devel] [PATCH v3 1/5] xen/spinlocks: in debug builds store cpu holding the lock

2019-09-03 Thread Juergen Gross
On 03.09.19 16:11, Jan Beulich wrote: On 29.08.2019 12:18, Juergen Gross wrote: --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -6,14 +6,21 @@ #include #ifndef NDEBUG -struct lock_debug { -s16 irq_safe; /* +1: IRQ-safe; 0: not IRQ-safe; -1: don't know yet */

Re: [Xen-devel] [PATCH v3 1/5] xen/spinlocks: in debug builds store cpu holding the lock

2019-09-03 Thread Jan Beulich
On 29.08.2019 12:18, Juergen Gross wrote: > --- a/xen/include/xen/spinlock.h > +++ b/xen/include/xen/spinlock.h > @@ -6,14 +6,21 @@ > #include > > #ifndef NDEBUG > -struct lock_debug { > -s16 irq_safe; /* +1: IRQ-safe; 0: not IRQ-safe; -1: don't know yet */ > +union lock_debug { > +

[Xen-devel] [PATCH v3 1/5] xen/spinlocks: in debug builds store cpu holding the lock

2019-08-29 Thread Juergen Gross
Add the cpu currently holding the lock to struct lock_debug. This makes analysis of locking errors easier and it can be tested whether the correct cpu is releasing a lock again. Signed-off-by: Juergen Gross --- V2: adjust types (Jan Beulich) --- xen/common/spinlock.c | 33