Re: [Xen-devel] [PATCH v3 12/15] x86/IRQ: add explicit tracing-enabled check to trace_irq_mask()

2019-07-04 Thread Jan Beulich
On 03.07.2019 20:41, Andrew Cooper wrote: > On 17/05/2019 11:51, Jan Beulich wrote: >> --- a/xen/arch/x86/irq.c >> +++ b/xen/arch/x86/irq.c >> @@ -137,6 +137,13 @@ static void trace_irq_mask(uint32_t even >> trace_var(event, 1, sizeof(d), ); >> } >> >> +static inline void

Re: [Xen-devel] [PATCH v3 12/15] x86/IRQ: add explicit tracing-enabled check to trace_irq_mask()

2019-07-03 Thread Andrew Cooper
On 17/05/2019 11:51, Jan Beulich wrote: > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -137,6 +137,13 @@ static void trace_irq_mask(uint32_t even > trace_var(event, 1, sizeof(d), ); > } > > +static inline void trace_irq_mask(uint32_t event, int irq, int vector, No inline. 

Re: [Xen-devel] [PATCH v3 12/15] x86/IRQ: add explicit tracing-enabled check to trace_irq_mask()

2019-05-20 Thread Roger Pau Monné
On Fri, May 17, 2019 at 04:51:50AM -0600, Jan Beulich wrote: > The setup for calling trace_var() (which itself checks tb_init_done) is > non-negligible, and hence a separate outer-most check is warranted. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné I think a macro or helper

[Xen-devel] [PATCH v3 12/15] x86/IRQ: add explicit tracing-enabled check to trace_irq_mask()

2019-05-17 Thread Jan Beulich
The setup for calling trace_var() (which itself checks tb_init_done) is non-negligible, and hence a separate outer-most check is warranted. Signed-off-by: Jan Beulich --- v3: New. --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -121,8 +121,8 @@ static void release_old_vec(struct irq_d