Re: [Xen-devel] [PATCH v3 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

>>> On 13.02.18 at 19:37, wrote: > Pardon any weird formatting, I'm replying on my phone. > > Because they are two different things. One is an assert to make sure > nothing wrong is happening with the EFER.SVME bit, and the other changes what > features are enabled. >

Re: [Xen-devel] [PATCH v3 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

Pardon any weird formatting, I'm replying on my phone. Because they are two different things. One is an assert to make sure nothing wrong is happening with the EFER.SVME bit, and the other changes what features are enabled. IIRC, most asserts are on their on ifs and not in a if statement

Re: [Xen-devel] [PATCH v3 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

>>> On 08.02.18 at 18:01, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -611,6 +611,12 @@ static void svm_update_guest_efer(struct vcpu *v) > if ( lma ) > new_efer |= EFER_LME; > vmcb_set_efer(vmcb, new_efer); > + > +

[Xen-devel] [PATCH v3 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

Only enable virtual VMLOAD/SAVE and VGIF if the guest EFER.SVME is set. Reported-by: Andrew Cooper Signed-off-by: Brian Woods --- xen/arch/x86/hvm/svm/nestedsvm.c| 66 + xen/arch/x86/hvm/svm/svm.c