Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-15 Thread Alexandru Stefan ISAILA
On Mi, 2018-02-14 at 19:11 +, Andrew Cooper wrote: > On 14/02/18 18:22, Andrew Cooper wrote: > > > > On 14/02/18 16:10, Alexandru Stefan ISAILA wrote: > > > > > > On Lu, 2018-02-12 at 15:54 +, Andrew Cooper wrote: > > > > > > > > On 12/02/18 15:08, Alexandru Isaila wrote: > > > > > > > > >

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-14 Thread Andrew Cooper
On 14/02/18 18:22, Andrew Cooper wrote: > On 14/02/18 16:10, Alexandru Stefan ISAILA wrote: >> On Lu, 2018-02-12 at 15:54 +, Andrew Cooper wrote: >>> On 12/02/18 15:08, Alexandru Isaila wrote: @@ -2619,14 +2634,31 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) br

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-14 Thread Andrew Cooper
On 14/02/18 16:10, Alexandru Stefan ISAILA wrote: > On Lu, 2018-02-12 at 15:54 +, Andrew Cooper wrote: >> On 12/02/18 15:08, Alexandru Isaila wrote: >>> @@ -2619,14 +2634,31 @@ void svm_vmexit_handler(struct >>> cpu_user_regs *regs) >>> break; >>> >>> case VMEXIT_EXCEPTION_BP: >>>

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-14 Thread Alexandru Stefan ISAILA
On Lu, 2018-02-12 at 15:54 +, Andrew Cooper wrote: > On 12/02/18 15:08, Alexandru Isaila wrote: > > > > @@ -2619,14 +2634,31 @@ void svm_vmexit_handler(struct > > cpu_user_regs *regs) > > break; > > > > case VMEXIT_EXCEPTION_BP: > > -if ( !v->domain->debugger_attached ) >

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-13 Thread Alexandru Stefan ISAILA
On Lu, 2018-02-12 at 15:54 +, Andrew Cooper wrote: > On 12/02/18 15:08, Alexandru Isaila wrote: > > > > @@ -2619,14 +2634,31 @@ void svm_vmexit_handler(struct > > cpu_user_regs *regs) > > break; > > > > case VMEXIT_EXCEPTION_BP: > > -if ( !v->domain->debugger_attached ) >

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-12 Thread Tamas K Lengyel
On Mon, Feb 12, 2018 at 8:54 AM, Andrew Cooper wrote: > On 12/02/18 15:08, Alexandru Isaila wrote: >> @@ -2619,14 +2634,31 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) >> break; >> >> case VMEXIT_EXCEPTION_BP: >> -if ( !v->domain->debugger_attached ) >> -

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-12 Thread Andrew Cooper
On 12/02/18 15:08, Alexandru Isaila wrote: > @@ -2619,14 +2634,31 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) > break; > > case VMEXIT_EXCEPTION_BP: > -if ( !v->domain->debugger_attached ) > -goto unexpected_exit_type; > -/* AMD Vol2, 15.11: IN

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-12 Thread Tamas K Lengyel
On Mon, Feb 12, 2018 at 8:08 AM, Alexandru Isaila wrote: > This commit implements the breakpoint events for svm. > At the moment, the Breakpoint vmexit is not forwarded to the monitor layer. This is a bit confusing as it sounds like as if you were saying that after this patch the event is not for

[Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-12 Thread Alexandru Isaila
This commit implements the breakpoint events for svm. At the moment, the Breakpoint vmexit is not forwarded to the monitor layer. This patch adds the hvm_monitor_debug call to the VMEXIT_EXCEPTION_BP. Also, the Software Breakpoint cap is moved from the Intel arch to the common part of the code. Si