Re: [Xen-devel] [PATCH v3 25/25] xen/arm: split domain_build.c

2018-08-16 Thread Stefano Stabellini
On Thu, 16 Aug 2018, Julien Grall wrote: > Hi Stefano, > > On 08/16/2018 01:25 AM, Stefano Stabellini wrote: > > On Mon, 13 Aug 2018, Julien Grall wrote: > > > > + > > > > +#ifndef CONFIG_ACPI > > > > +static inline int prepare_acpi(struct domain *d, struct kernel_info > > > > *kinfo) > > > > +{

Re: [Xen-devel] [PATCH v3 25/25] xen/arm: split domain_build.c

2018-08-16 Thread Julien Grall
Hi Stefano, On 08/16/2018 01:25 AM, Stefano Stabellini wrote: On Mon, 13 Aug 2018, Julien Grall wrote: + +#ifndef CONFIG_ACPI +static inline int prepare_acpi(struct domain *d, struct kernel_info *kinfo) +{ +/* Only booting with ACPI will hit here */ +BUG(); +return -EINVAL; +}

Re: [Xen-devel] [PATCH v3 25/25] xen/arm: split domain_build.c

2018-08-15 Thread Stefano Stabellini
On Mon, 13 Aug 2018, Julien Grall wrote: > Hi, > > On 01/08/18 00:28, Stefano Stabellini wrote: > > domain_build.c is too large. > > > > Move all the ACPI specific device tree generating functions from > > domain_build.c to acpi/acpi_dt_build.c. > > The directory is called "acpi" so there is no

Re: [Xen-devel] [PATCH v3 25/25] xen/arm: split domain_build.c

2018-08-13 Thread Julien Grall
Hi, On 01/08/18 00:28, Stefano Stabellini wrote: domain_build.c is too large. Move all the ACPI specific device tree generating functions from domain_build.c to acpi/acpi_dt_build.c. The directory is called "acpi" so there is no point to duplicate in the filename. Also, looking at the

[Xen-devel] [PATCH v3 25/25] xen/arm: split domain_build.c

2018-07-31 Thread Stefano Stabellini
domain_build.c is too large. Move all the ACPI specific device tree generating functions from domain_build.c to acpi/acpi_dt_build.c. Signed-off-by: Stefano Stabellini --- xen/arch/arm/acpi/Makefile| 1 + xen/arch/arm/acpi/acpi_dt_build.c | 591 ++