Re: [Xen-devel] [PATCH v3 3/6] libxl: add infrastructure to track and query 'retired' domids

2020-01-17 Thread Ian Jackson
Durrant, Paul writes ("RE: [PATCH v3 3/6] libxl: add infrastructure to track and query 'retired' domids"): > [Ian;] > > I'm not sure why you bother with fgets into a buffer, when you could > > just use fscanf rather than sscanf. Your code doesn't need to take > > much care about weird syntax

Re: [Xen-devel] [PATCH v3 3/6] libxl: add infrastructure to track and query 'retired' domids

2020-01-17 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 16 January 2020 19:28 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Anthony Perard > > Subject: Re: [PATCH v3 3/6] libxl: add infrastructure to track and query > 'retired' domids > > Thanks. I think this is the

Re: [Xen-devel] [PATCH v3 3/6] libxl: add infrastructure to track and query 'retired' domids

2020-01-16 Thread Ian Jackson
Thanks. I think this is the algorithm as we discussed, thanks. I have some comments about the implementation... Paul Durrant writes ("[PATCH v3 3/6] libxl: add infrastructure to track and query 'retired' domids"): > A domid is considered retired if the domain it represents was destroyed > less

[Xen-devel] [PATCH v3 3/6] libxl: add infrastructure to track and query 'retired' domids

2020-01-16 Thread Paul Durrant
A domid is considered retired if the domain it represents was destroyed less than a specified number of seconds ago. The number can be set using the environment variable LIBXL_DOMID_MAX_RETIREMENT. If the variable does not exist then a default value of 60s is used. Whenever a domain is destroyed,