Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Boris Ostrovsky
On 9/7/18 10:31 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Juergen Gross
On 11/09/18 12:48, Olaf Hering wrote: > Am Tue, 11 Sep 2018 09:52:58 +0200 > schrieb Olaf Hering : > >> As Jürgen suggested in another mail, Xen should probably disable hotplugging >> for cpu#0 in the generic setup code. Then cpu_is_hotpluggable(cpu) would >> do the right thing. > > The relevant

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Olaf Hering
Am Tue, 11 Sep 2018 09:52:58 +0200 schrieb Olaf Hering : > As Jürgen suggested in another mail, Xen should probably disable hotplugging > for cpu#0 in the generic setup code. Then cpu_is_hotpluggable(cpu) would > do the right thing. The relevant code is all private to arch/x86/kernel/topology.c.

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Juergen Gross
On 11/09/18 09:52, Olaf Hering wrote: > Am Fri, 7 Sep 2018 12:56:37 -0400 > schrieb Boris Ostrovsky : > >> I was hoping you'd respond to my question about warning. > > It looks like CONFIG_BOOTPARAM_HOTPLUG_CPU0=y is the reason for the warning. > As Jürgen suggested in another mail, Xen should

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Olaf Hering
Am Fri, 7 Sep 2018 12:56:37 -0400 schrieb Boris Ostrovsky : > I was hoping you'd respond to my question about warning. It looks like CONFIG_BOOTPARAM_HOTPLUG_CPU0=y is the reason for the warning. As Jürgen suggested in another mail, Xen should probably disable hotplugging for cpu#0 in the

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-10 Thread Olaf Hering
Am Fri, 7 Sep 2018 12:56:37 -0400 schrieb Boris Ostrovsky : > I was hoping you'd respond to my question about warning. > > root@haswell> xl vcpu-set 3 0 > and in the guest > > [root@vm-0238 ~]# [   32.866955] [ cut here ] > [   32.866963] spinlock on CPU0 exists on

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Boris Ostrovsky
On 09/07/2018 10:31 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Juergen Gross
On 07/09/18 16:31, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted