Re: [Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

2018-02-19 Thread Roger Pau Monné
On Mon, Feb 19, 2018 at 09:14:30AM -0700, Jan Beulich wrote: > >>> On 19.02.18 at 17:05, wrote: > > On Mon, Feb 19, 2018 at 08:43:51AM -0700, Jan Beulich wrote: > >> >>> On 19.02.18 at 15:16, wrote: > >> > --- > >> > xen/arch/x86/Makefile | 6 +++--- > >> > xen/arch/x86/Rules.mk | 5 + > >> >

Re: [Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

2018-02-19 Thread Jan Beulich
>>> On 19.02.18 at 17:05, wrote: > On Mon, Feb 19, 2018 at 08:43:51AM -0700, Jan Beulich wrote: >> >>> On 19.02.18 at 15:16, wrote: >> > --- >> > xen/arch/x86/Makefile | 6 +++--- >> > xen/arch/x86/Rules.mk | 5 + >> > xen/include/Makefile | 2 +- >> > 3 files changed, 5 insertions(+), 8 de

Re: [Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

2018-02-19 Thread Roger Pau Monné
On Mon, Feb 19, 2018 at 08:43:51AM -0700, Jan Beulich wrote: > >>> On 19.02.18 at 15:16, wrote: > > --- > > xen/arch/x86/Makefile | 6 +++--- > > xen/arch/x86/Rules.mk | 5 + > > xen/include/Makefile | 2 +- > > 3 files changed, 5 insertions(+), 8 deletions(-) > > What about the "%.i: %.c",

Re: [Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

2018-02-19 Thread Jan Beulich
>>> On 19.02.18 at 15:16, wrote: > --- > xen/arch/x86/Makefile | 6 +++--- > xen/arch/x86/Rules.mk | 5 + > xen/include/Makefile | 2 +- > 3 files changed, 5 insertions(+), 8 deletions(-) What about the "%.i: %.c", "%.s: %.c", and "%.s: %.S" rules near the end of xen/Rules.mk? Jan __

[Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

2018-02-19 Thread Roger Pau Monne
If the assembler is not used. This happens when using cc -E or cc -S for example. GCC will just ignore the -Wa,... when the assembler is not called, but clang will complain loudly and fail. Also enable passing -Wa,-I$(BASEDIR)/include to clang now that it's safe to do so. Signed-off-by: Roger Pau