Re: [Xen-devel] [PATCH v7 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-10-31 Thread Wei Liu
On Wed, Sep 12, 2018 at 11:29:32AM +0100, Julien Grall wrote: > > > On 09/12/2018 12:09 AM, Stefano Stabellini wrote: > > > > + > > > > +/* Constants for libxl_static_shm */ > > > > +#define LIBXL_SSHM_RANGE_UNKNOWN UINT64_MAX > > > > +#define LIBXL_SSHM_ID_MAXLEN128 > > > > > > Why do you

Re: [Xen-devel] [PATCH v7 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-09-12 Thread Julien Grall
On 09/12/2018 12:09 AM, Stefano Stabellini wrote: + +/* Constants for libxl_static_shm */ +#define LIBXL_SSHM_RANGE_UNKNOWN UINT64_MAX +#define LIBXL_SSHM_ID_MAXLEN128 Why do you need to bound the size of the string? It is passed by the user, it is good to be clear about the max size?

Re: [Xen-devel] [PATCH v7 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-09-11 Thread Stefano Stabellini
On Tue, 28 Aug 2018, Julien Grall wrote: > Hi, > > On 11/08/18 01:00, Stefano Stabellini wrote: > > From: Zhongze Liu > > > > Author: Zhongze Liu > > > > Add a new structure to the IDL family to represent static shared memory > > regions > > as proposed in the proposal "Allow setting up

Re: [Xen-devel] [PATCH v7 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-08-28 Thread Julien Grall
Hi, On 11/08/18 01:00, Stefano Stabellini wrote: From: Zhongze Liu Author: Zhongze Liu Add a new structure to the IDL family to represent static shared memory regions as proposed in the proposal "Allow setting up shared memory areas between VMs from xl config file" (see [1]). And deleted

[Xen-devel] [PATCH v7 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-08-10 Thread Stefano Stabellini
From: Zhongze Liu Author: Zhongze Liu Add a new structure to the IDL family to represent static shared memory regions as proposed in the proposal "Allow setting up shared memory areas between VMs from xl config file" (see [1]). And deleted some trailing white spaces. [1]