Re: [Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-12-03 Thread Andre Przywara
On Mon, 3 Dec 2018 14:33:08 +0200 Andrii Anisov wrote: Hi Andrii, > On 29.11.18 14:14, Andre Przywara wrote: > > Nah, please don't do this. > Sorry for making you crying looking at this code. > It's terrible, I know. It's rather an idea. > > > Can you show that atomic bit ops are a > >

Re: [Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-12-03 Thread Julien Grall
On 03/12/2018 13:05, Andrii Anisov wrote: Hello Julien, On 03.12.18 14:58, Julien Grall wrote: That's micro optimizing Xen... there are better (and less risky) place to look for optimization. I would appreciate you point me those places. I already pointed them in various threads with you.

Re: [Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-12-03 Thread Andrii Anisov
Hello Julien, On 03.12.18 14:58, Julien Grall wrote: That's micro optimizing Xen... there are better (and less risky) place to look for optimization. I would appreciate you point me those places. Knowing how fragile the locking is on the old vGIC, the risk of micro-optimizing is not worth

Re: [Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-12-03 Thread Julien Grall
Hi Andrii, On 03/12/2018 12:33, Andrii Anisov wrote: On 29.11.18 14:14, Andre Przywara wrote: Nah, please don't do this. Sorry for making you crying looking at this code. It's terrible, I know. It's rather an idea. Can you show that atomic bit ops are a problem? They shouldn't be expensive

Re: [Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-12-03 Thread Andrii Anisov
Hello Andre, On 29.11.18 14:14, Andre Przywara wrote: Nah, please don't do this. Sorry for making you crying looking at this code. It's terrible, I know. It's rather an idea. Can you show that atomic bit ops are a problem? They shouldn't be expensive unless contended, also pretty lightweight

Re: [Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-11-29 Thread Julien Grall
Hi, On 29/11/2018 12:14, Andre Przywara wrote: On Wed, 28 Nov 2018 23:32:05 +0200 Andrii Anisov wrote: Hi, From: Andrii Anisov All bit operations for gic, vgic and gic-vgic are performed under spinlocks, so there is no need for atomic bit ops here, they only introduce excessive call to

Re: [Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-11-29 Thread Andre Przywara
On Wed, 28 Nov 2018 23:32:05 +0200 Andrii Anisov wrote: Hi, > From: Andrii Anisov > > All bit operations for gic, vgic and gic-vgic are performed under > spinlocks, so there is no need for atomic bit ops here, they only > introduce excessive call to functions used more expensive exclusive >

[Xen-devel] [RFC 10/16] gic:vgic:gic-vgic: introduce non-atomic bitops

2018-11-28 Thread Andrii Anisov
From: Andrii Anisov All bit operations for gic, vgic and gic-vgic are performed under spinlocks, so there is no need for atomic bit ops here, they only introduce excessive call to functions used more expensive exclusive ARM instructions. Signed-off-by: Andrii Anisov ---