Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

On 27/02/18 13:54, Andre Przywara wrote: Hi, On 19/02/18 14:13, Julien Grall wrote: On 19/02/18 12:41, Andre Przywara wrote: Hi, Hi, On 16/02/18 16:57, Julien Grall wrote: On 09/02/18 14:39, Andre Przywara wrote: +    spin_lock_irqsave(>lock, flags); +    if ( enable ) +    { +  

Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

Hi, On 19/02/18 14:13, Julien Grall wrote: > > > On 19/02/18 12:41, Andre Przywara wrote: >> Hi, > > Hi, > >> On 16/02/18 16:57, Julien Grall wrote: >>> On 09/02/18 14:39, Andre Przywara wrote: +    spin_lock_irqsave(>lock, flags); +    if ( enable ) +    { +   

Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

Hi Andre, On 23/02/18 15:18, Andre Przywara wrote: +    irq_desc_t *desc; +    int i; +    unsigned long flags; +    enum vgic_irq_config config; + +    for_each_set_bit( i, , len * 8 ) +    { +    struct vgic_irq *irq; + +    irq = vgic_get_irq(vcpu->domain, vcpu, intid + i); + +   

Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

Hi, On 16/02/18 16:57, Julien Grall wrote: > Hi Andre, > > On 09/02/18 14:39, Andre Przywara wrote: >> As the enable register handlers are shared between the v2 and v3 >> emulation, their implementation goes into vgic-mmio.c, to be easily >> referenced from the v3 emulation as well later. >> >>

Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

On 19/02/18 12:41, Andre Przywara wrote: Hi, Hi, On 16/02/18 16:57, Julien Grall wrote: On 09/02/18 14:39, Andre Przywara wrote: +    spin_lock_irqsave(>lock, flags); +    if ( enable ) +    { +    gic_set_irq_type(desc, irq_type == VGIC_CONFIG_LEVEL ? +

Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

Hi, On 16/02/18 16:57, Julien Grall wrote: > Hi Andre, > > On 09/02/18 14:39, Andre Przywara wrote: >> As the enable register handlers are shared between the v2 and v3 >> emulation, their implementation goes into vgic-mmio.c, to be easily >> referenced from the v3 emulation as well later. >> >>

Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

Hi Andre, On 09/02/18 14:39, Andre Przywara wrote: As the enable register handlers are shared between the v2 and v3 emulation, their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. Signed-off-by: Andre Przywara ---

[Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

As the enable register handlers are shared between the v2 and v3 emulation, their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. Signed-off-by: Andre Przywara --- xen/arch/arm/vgic/vgic-mmio-v2.c | 4 +-