Re: [Xen-devel] Ping: [PATCH] x86: improve vCPU selection in pagetable_dying()

2018-10-04 Thread Jan Beulich
>>> On 03.10.18 at 18:56, wrote: > On 09/26/2018 08:04 AM, Jan Beulich wrote: > On 25.09.18 at 18:22, wrote: >>> On 18/09/18 13:44, Jan Beulich wrote: >>> On 10.09.18 at 16:02, wrote: > Rather than unconditionally using vCPU 0, use the current vCPU if the > subject domain is the

Re: [Xen-devel] Ping: [PATCH] x86: improve vCPU selection in pagetable_dying()

2018-10-03 Thread Tim Deegan
At 17:56 +0100 on 03 Oct (1538589366), George Dunlap wrote: > On 09/26/2018 08:04 AM, Jan Beulich wrote: > > Looking at things again (in particular > > the comment ahead of pagetable_dying()) I now actually wonder why > > HVMOP_pagetable_dying is permitted to be called by other than a domain > >

Re: [Xen-devel] Ping: [PATCH] x86: improve vCPU selection in pagetable_dying()

2018-10-03 Thread George Dunlap
On 09/26/2018 08:04 AM, Jan Beulich wrote: On 25.09.18 at 18:22, wrote: >> On 18/09/18 13:44, Jan Beulich wrote: >> On 10.09.18 at 16:02, wrote: Rather than unconditionally using vCPU 0, use the current vCPU if the subject domain is the current one. Signed-off-by:

Re: [Xen-devel] Ping: [PATCH] x86: improve vCPU selection in pagetable_dying()

2018-09-26 Thread Jan Beulich
>>> On 25.09.18 at 18:22, wrote: > On 18/09/18 13:44, Jan Beulich wrote: > On 10.09.18 at 16:02, wrote: >>> Rather than unconditionally using vCPU 0, use the current vCPU if the >>> subject domain is the current one. >>> >>> Signed-off-by: Jan Beulich > > What improvement is this intended

Re: [Xen-devel] Ping: [PATCH] x86: improve vCPU selection in pagetable_dying()

2018-09-25 Thread Andrew Cooper
On 18/09/18 13:44, Jan Beulich wrote: On 10.09.18 at 16:02, wrote: >> Rather than unconditionally using vCPU 0, use the current vCPU if the >> subject domain is the current one. >> >> Signed-off-by: Jan Beulich What improvement is this intended to bring? Shadows are per-domain, and the

[Xen-devel] Ping: [PATCH] x86: improve vCPU selection in pagetable_dying()

2018-09-18 Thread Jan Beulich
>>> On 10.09.18 at 16:02, wrote: > Rather than unconditionally using vCPU 0, use the current vCPU if the > subject domain is the current one. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -858,7 +858,7 @@ void pagetable_dying(struct