Re: [Xen-devel] [PATCH v2 for 4.5] xen/arm: Add support for GICv3 for domU

2014-11-11 Thread Julien Grall
in the header file wouldn't hurt though. It looks like that Ian has already pushed the patch. Do I need to send a follow-up? Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH OSSTEST v2 18/20] Osstest/Debian: Add clk_ignore_unused to default command line

2014-11-11 Thread Julien Grall
to DOM0 without marking as disabled. It would avoid DOM0 to mess up the clock while everything would be catch via the vuart implementation in Xen. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] fix commit xen/arm: Add support for GICv3 for domU

2014-11-12 Thread Julien Grall
but XEN_DOMCTL_arm_configure_domain elsewhere. Sorry, I renamed the hypercall on the later version and didn't check the XSM build. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v9 0/13] introduce GNTTABOP_cache_flush

2014-11-12 Thread Julien Grall
anymore: Tested-by: Julien Grall julien.gr...@linaro.org Regards, Changes in v9: - remove BUG_ON from the loop in dma_cache_maint; - add static inline for xen_dma_unmap_page, xen_dma_sync_single_for_cpu, xen_dma_sync_single_for_device; - map_page is always present, don't check whether it's

Re: [Xen-devel] [PATCH OSSTEST v2 18/20] Osstest/Debian: Add clk_ignore_unused to default command line

2014-11-12 Thread Julien Grall
On 11/12/2014 10:07 AM, Ian Campbell wrote: On Tue, 2014-11-11 at 17:50 +0100, Julien Grall wrote: Hi, Somehow I missed this email. On 30/10/2014 13:33, Ian Campbell wrote: create ! title it arm: domain 0 disables clocks which are in fact being used thanks On Wed, 2014-10-29 at 16:39

Re: [Xen-devel] [PATCH ARM v8 2/4] mini-os: arm: interrupt controller

2014-11-14 Thread Julien Grall
Hi Thomas, On 14/11/2014 10:22, Thomas Leonard wrote: On 28 October 2014 15:51, Julien Grall julien.gr...@linaro.org wrote: On 10/28/2014 03:43 PM, Thomas Leonard wrote: On 28 October 2014 15:25, Julien Grall julien.gr...@linaro.org wrote: On 10/28/2014 03:15 PM, Thomas Leonard wrote: On 22

Re: [Xen-devel] [PATCH ARM v8 2/4] mini-os: arm: interrupt controller

2014-11-14 Thread Julien Grall
On 14/11/2014 11:42, Ian Campbell wrote: On Fri, 2014-11-14 at 11:33 +, Julien Grall wrote: Though IIRC, mini-os for ARM is not yet SMP. It's difficult to see what needs to be done to support code that doesn't exist yet. For example, would gic_init be called once, or once per processor

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Julien Grall
that the next GIC series impact this code as the next driver is only compiled for arm64 (GICv3 doesn't exist on arm32). Though, there was some refactoring. The interrupt management has also been reworked for Xen 4.5 to avoid maintenance interrupt. I would give a look on this part. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Julien Grall
. Would an empty structure and used it be better? Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Julien Grall
On 11/18/2014 03:10 PM, Ian Jackson wrote: Julien Grall writes (Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU): I need to create an empty structure. Is the dummy field really needed? Empty structs are a gcc extension (`(gcc-4.4) Empty Structures'). I would be very

[Xen-devel] Empty struct in public headers Was: Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Julien Grall
(Rename the mail and strip the cc list) On 11/18/2014 03:35 PM, Ian Jackson wrote: Julien Grall writes (Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU): On 11/18/2014 03:10 PM, Ian Jackson wrote: Empty structs are a gcc extension (`(gcc-4.4) Empty Structures'). I would

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Julien Grall
of the 2 solutions are valid, Ian Jackson was suggesting to use struct { char dummy; } Would it be ok for you? Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Empty struct in public headers Was: Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Julien Grall
On 11/18/2014 04:21 PM, Ian Campbell wrote: On Tue, 2014-11-18 at 15:49 +, Julien Grall wrote: (Rename the mail and strip the cc list) On 11/18/2014 03:35 PM, Ian Jackson wrote: Julien Grall writes (Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU): On 11/18/2014 03:10

Re: [Xen-devel] [PATCH for-4.5 1/4] xen: arm: Add earlyprintk for McDivitt.

2014-11-18 Thread Julien Grall
as we don't use the initialization function (EARLY_PRINTK_INIT_UART is not set). With the EARLY_PRINTK_BAUD dropped, this could be merged with the xgene-storm early printk (I didn't really understand why the baud rate is different). But I don't think it's 4.5 material. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH for-4.5 2/4] xen: arm: correct off by one in xgene-storm's map_one_mmio

2014-11-18 Thread Julien Grall
, what, start, d-domain_id); As you fixed the previous printf format. I would fix this one too. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.5 3/4] xen: arm: correct specific mappings for PCIE0 on X-Gene

2014-11-18 Thread Julien Grall
Campbell ian.campb...@citrix.com Reviewed-by: Julien Grall julien.gr...@linaro.org Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.5 4/4] xen: arm: Support the other 4 PCI buses on Xgene

2014-11-18 Thread Julien Grall
. +} + +if ( ret 0 ) +return ret; + +printk(Mapped additional regions for PCIe device at 0x%PRIx64\n, + addr); Printing the device tree path would be more helpful than the address. Regards, -- Julien Grall ___ Xen-devel

[Xen-devel] [RFC for 4.6] xen: Extend DOMCTL createdomain to support arch configuration

2014-11-18 Thread Julien Grall
introduced in Xen 4.5, as it has been made useless. Signed-off-by: Julien Grall julien.gr...@linaro.org Cc: Daniel De Graaf dgde...@tycho.nsa.gov Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: Keir Fraser k...@xen.org Cc: Jan

[Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-18 Thread Julien Grall
/archives/html/xen-devel/2014-11/msg00060.html Signed-off-by: Julien Grall julien.gr...@linaro.org CC: Don Slutz dsl...@verizon.com --- I would like to see this patch in Xen 4.5 and backported to Xen 4.4 (first time the script has been introduced). Developpers using this script won't

Re: [Xen-devel] [PATCH for-4.5 4/4] xen: arm: Support the other 4 PCI buses on Xgene

2014-11-19 Thread Julien Grall
Hi Ian, On 19/11/2014 09:56, Ian Campbell wrote: On Tue, 2014-11-18 at 17:15 +, Julien Grall wrote: +default: +/* Ignore unknown PCI busses */ I would add a printk(Ignoring PCI busses %s\n, dt_node_full_name(dev)); +ret = 0; +break

Re: [Xen-devel] [PATCH for-4.5 4/4] xen: arm: Support the other 4 PCI buses on Xgene

2014-11-19 Thread Julien Grall
On 19/11/2014 10:18, Ian Campbell wrote: On Wed, 2014-11-19 at 10:06 +, Julien Grall wrote: Hi Ian, On 19/11/2014 09:56, Ian Campbell wrote: On Tue, 2014-11-18 at 17:15 +, Julien Grall wrote: +default: +/* Ignore unknown PCI busses */ I would add a printk

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Julien Grall
On 11/19/2014 12:40 PM, Andrii Tseglytskyi wrote: Hi Julien, On Wed, Nov 19, 2014 at 2:23 PM, Julien Grall julien.gr...@linaro.org wrote: On 11/19/2014 12:17 PM, Stefano Stabellini wrote: On Wed, 19 Nov 2014, Ian Campbell wrote: On Wed, 2014-11-19 at 11:42 +, Stefano Stabellini wrote

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Julien Grall
On 11/19/2014 01:30 PM, Andrii Tseglytskyi wrote: On Wed, Nov 19, 2014 at 3:26 PM, Julien Grall julien.gr...@linaro.org wrote: On 11/19/2014 12:40 PM, Andrii Tseglytskyi wrote: Hi Julien, On Wed, Nov 19, 2014 at 2:23 PM, Julien Grall julien.gr...@linaro.org wrote: On 11/19/2014 12:17 PM

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Julien Grall
this somewhere. Just in case someone decide to add code in maintenance interrupt later. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Julien Grall
On 11/20/2014 10:28 AM, Stefano Stabellini wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: 19 лист. 2014 20:32, користувач Stefano Stabellini stefano.stabell...@eu.citrix.com написав: On Wed, 19 Nov 2014, Julien Grall wrote: On 11/19/2014 06:14 PM, Stefano Stabellini wrote: That's

Re: [Xen-devel] [PATCH v2 for-4.5 1/5] xen: arm: Add earlyprintk for McDivitt.

2014-11-20 Thread Julien Grall
Hi Ian, On 11/19/2014 03:28 PM, Ian Campbell wrote: Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: Remove pointless/unused baud rate setting. A bunch of other entries have these, but cleaning them up is out of scope here I think. Agreed. Reviewed-by: Julien Grall

Re: [Xen-devel] [PATCH v2 for-4.5 2/5] xen: arm: Drop EARLY_PRINTK_BAUD from entries which don't set ..._INIT_UART

2014-11-20 Thread Julien Grall
Maybe use 8250 should be replaced by other UARTs drivers? Signed-off-by: Ian Campbell ian.campb...@citrix.com Reviewed-by: Julien Grall julien.gr...@linaro.org Regards, --- v2: New patch. --- xen/arch/arm/Rules.mk |7 --- 1 file changed, 7 deletions(-) diff --git a/xen/arch/arm

Re: [Xen-devel] [PATCH v2 for-4.5 3/5] xen: arm: correct off by one in xgene-storm's map_one_mmio

2014-11-20 Thread Julien Grall
to 16 digits as for a paddr when they are frame numbers is just confusing. Signed-off-by: Ian Campbell ian.campb...@citrix.com Reviewed-by: Julien Grall julien.gr...@linaro.org Regards, --- v2: Fix the other printk format string too. --- xen/arch/arm/platforms/xgene-storm.c |6

Re: [Xen-devel] [PATCH v2 for-4.5 5/5] xen: arm: Support the other 4 PCI buses on Xgene

2014-11-20 Thread Julien Grall
; +} + +if ( ret 0 ) +return ret; +} + +return 0; +} + static void xgene_storm_reset(void) { void __iomem *addr; -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC for 4.6] xen: Extend DOMCTL createdomain to support arch configuration

2014-11-20 Thread Julien Grall
(if internally to the hypervisor or tools they turn out to make the code much better readable, each such component could still introduce one on its own). Ok. I will drop them and rename the structure to xen_arch_domainconfig; Regards, -- Julien Grall ___ Xen

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
Hi Ian, On 11/20/2014 04:08 PM, Ian Campbell wrote: On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: By default, the script get_maintainer.pl will remove duplicates email as soon as it appends the list of maintainers of a new file, and therefore override the role of the developper

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
On 11/20/2014 04:15 PM, Julien Grall wrote: Hi Ian, On 11/20/2014 04:08 PM, Ian Campbell wrote: On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: By default, the script get_maintainer.pl will remove duplicates email as soon as it appends the list of maintainers of a new file

Re: [Xen-devel] [PATCH v2 for-4.5] xen/arm: clear UIE on hypervisor entry

2014-11-20 Thread Julien Grall
Hi Stefano, On 11/20/2014 03:54 PM, Stefano Stabellini wrote: On Thu, 20 Nov 2014, Julien Grall wrote: On 11/20/2014 11:02 AM, Julien Grall wrote: Hi Stefano, On 11/20/2014 10:53 AM, Stefano Stabellini wrote: UIE being set can cause maintenance interrupts to occur when Xen writes to one

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
On 11/20/2014 04:30 PM, Ian Campbell wrote: On Thu, 2014-11-20 at 16:15 +, Julien Grall wrote: Hi Ian, On 11/20/2014 04:08 PM, Ian Campbell wrote: On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: By default, the script get_maintainer.pl will remove duplicates email as soon

[Xen-devel] [PATCH v2 for 4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
-off-by: Julien Grall julien.gr...@linaro.org CC: Don Slutz dsl...@verizon.com --- Changes in v2: - Rework the commit message to explain the problem and the solution more clearly I would like to see this patch in Xen 4.5 and backported to Xen 4.4 (first time the script

Re: [Xen-devel] [PATCH 2/4] introduce arch_get_features()

2014-11-21 Thread Julien Grall
Signed-off-by: Juergen Gross jgr...@suse.com For the ARM part: Reviewed-by: Julien Grall julien.gr...@linaro.org Regards, --- xen/arch/arm/domain.c| 5 + xen/arch/x86/domain.c| 30 ++ xen/common/kernel.c | 22 ++ xen/include

Re: [Xen-devel] [PATCH v2 for-4.5] xen/arm: clear UIE on hypervisor entry

2014-11-21 Thread Julien Grall
Hi Stefano, On 20/11/2014 15:54, Stefano Stabellini wrote: On Thu, 20 Nov 2014, Julien Grall wrote: On 11/20/2014 11:02 AM, Julien Grall wrote: Hi Stefano, On 11/20/2014 10:53 AM, Stefano Stabellini wrote: UIE being set can cause maintenance interrupts to occur when Xen writes to one

[Xen-devel] [RFC v2] Add support for Xen ARM guest on FreeBSD

2014-11-23 Thread Julien Grall
$ cat freebsd.xl kernel=kernel memory=64 name=freebsd vcpus=1 autoballon=off disk=[ 'phy:/dev/loop0,xvda,w' ] $ losetup /dev/loop0 xenvm.img $ xl create freebsd.xl $ xl console freebsd -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http

[Xen-devel] [PATCH for-4.5] xen/arm: Fix virtual timer on ARMv8 Model

2014-11-25 Thread Julien Grall
for Xen 4.6. Signed-off-by: Julien Grall julien.gr...@linaro.org --- This patch is a bug fix candidate for Xen 4.5. Any ARMv8 model may randomly crash when running Xen. This patch don't inject the virtual timer interrupt if the current VCPU is the idle one. Entering in this function with the idle VCPU

Re: [Xen-devel] [PATCH for-4.5] xen/arm: Fix virtual timer on ARMv8 Model

2014-11-27 Thread Julien Grall
Hi Stefano, On 27/11/14 10:51, Stefano Stabellini wrote: On Thu, 27 Nov 2014, Ian Campbell wrote: On Tue, 2014-11-25 at 17:44 +, Julien Grall wrote: ARMv8 model may not disable correctly the timer interrupt when Xen correct disable context switch to an idle vCPU. Therefore Xen may

Re: [Xen-devel] [PATCH for-4.5] xen/arm: Fix virtual timer on ARMv8 Model

2014-11-27 Thread Julien Grall
Hi Ian, On 27/11/14 10:40, Ian Campbell wrote: On Tue, 2014-11-25 at 17:44 +, Julien Grall wrote: ARMv8 model may not disable correctly the timer interrupt when Xen correct disable context switch to an idle vCPU. Therefore Xen may receive a spurious context switches and s/spurious

Re: [Xen-devel] [PATCH for-4.5] xen/arm: Fix virtual timer on ARMv8 Model

2014-11-27 Thread Julien Grall
Hi, On 25/11/14 17:44, Julien Grall wrote: ARMv8 model may not disable correctly the timer interrupt when Xen context switch to an idle vCPU. Therefore Xen may receive a spurious timer interrupt. As the idle domain doesn't have vGIC, Xen will crash when trying to inject the interrupt

Re: [Xen-devel] [PATCH for-4.5] xen/arm: Fix virtual timer on ARMv8 Model

2014-11-28 Thread Julien Grall
Hi Ian, On 28/11/14 12:32, Ian Campbell wrote: On Thu, 2014-11-27 at 18:02 +, Julien Grall wrote: I propose to reword the commit message into: You'll want to change the code comment too I think. It was my plan. I will send a new version during the day. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH for-4.5] xen/arm: Fix virtual timer on ARMv8 Model

2014-11-28 Thread Julien Grall
Hi Ian, On 28/11/14 11:47, Ian Campbell wrote: On Thu, 2014-11-27 at 18:02 +, Julien Grall wrote: state at the GIC level. This would also avoid masking the output signal and requires specific handling in the guest OS. which requires? It doesn't seem quite right to me otherwise, since

[Xen-devel] [PATCH] xen/arm: Handle platforms with edge-triggered virtual timer

2014-11-28 Thread Julien Grall
for that reason too. Sadly, this solution requires some refactoring which would not be suitable for a freeze exception for the Xen 4.5 release. For now implement a temporary solution which ignores the virtual timer interrupt when the idle VCPU is running. Signed-off-by: Julien Grall julien.gr

Re: [Xen-devel] [PATCH] xen/arm: Handle platforms with edge-triggered virtual timer

2014-11-28 Thread Julien Grall
I forgot to add for 4.5 in the commit title. On 28/11/14 15:17, Julien Grall wrote: This patch is a bug fix candidate for Xen 4.5 and backport for Xen 4.4. It affects at least Xgene platform and ARMv8 models where Xen may randomly crash. Thinking a bit more to this. I believe it's possible

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Julien Grall
to modify the ARM bits which is using the spinlock. See arch/arm/mm.c Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Julien Grall
Hi, On 02/12/14 13:03, Egger, Christoph wrote: On 2014/12/02 13:35, Julien Grall wrote: Hi Christoph, On 02/12/14 10:06, Christoph Egger wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 522c43d..37c13b1 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4565,7

Re: [Xen-devel] [PATCH] xen/arm: Handle platforms with edge-triggered virtual timer

2014-12-02 Thread Julien Grall
Hi Ian, On 02/12/14 13:54, Ian Campbell wrote: On Fri, 2014-11-28 at 15:17 +, Julien Grall wrote: Some platforms (such as Xgene and ARMv8 models) use an edge-triggered interrupt for the virtual timer. Even if the timer output signal is masked in the context switch, the GIC will keep

Re: [Xen-devel] [PATCH] xen/arm: Handle platforms with edge-triggered virtual timer

2014-12-02 Thread Julien Grall
On 02/12/14 14:21, Ian Campbell wrote: On Tue, 2014-12-02 at 14:08 +, Julien Grall wrote: Hi Ian, On 02/12/14 13:54, Ian Campbell wrote: On Fri, 2014-11-28 at 15:17 +, Julien Grall wrote: Some platforms (such as Xgene and ARMv8 models) use an edge-triggered interrupt

Re: [Xen-devel] [v8][PATCH 13/17] xen/mem_access: don't allow accessing reserved device memory

2014-12-02 Thread Julien Grall
to at least stub those bits for ARM. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC v2] Add support for Xen ARM guest on FreeBSD

2014-12-02 Thread Julien Grall
Hello Andrew, On 28/11/2014 13:57, Andrew Turner wrote: On Sun, 23 Nov 2014 22:35:36 + Julien Grall julien.gr...@linaro.org wrote: Major changes in this new version: * Add Device Tree support via Linux Boot ABI * Add zImage support * Netfront support

Re: [Xen-devel] [RFC v2] Add support for Xen ARM guest on FreeBSD

2014-12-03 Thread Julien Grall
if necessary. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 4/9] xen: introduce XEN_DOMCTL_devour

2014-12-04 Thread Julien Grall
, the code in assign_pages makes more sense. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] xen/arm: uart interrupts handling

2014-12-04 Thread Julien Grall
when data is read or write into the fifo. So we should not clear automatically. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 4/9] xen: introduce XEN_DOMCTL_devour

2014-12-04 Thread Julien Grall
On 04/12/14 15:12, Vitaly Kuznetsov wrote: Julien Grall julien.gr...@linaro.org writes: Hi Vitaly, On 03/12/2014 17:16, Vitaly Kuznetsov wrote: New operation sets the 'recipient' domain which will recieve all s/recieve/receive/ memory pages from a particular domain and kills

[Xen-devel] [PATCH for-4.5] xen/arm: Correct the opcode for BUG_INSTR on arm32

2014-12-04 Thread Julien Grall
-by: Julien Grall julien.gr...@linaro.org --- Not sure, why I dropped the 0 when I implemented the patch... This is a bug fixed for Xen 4.5. This is only affected ARM32 where the BUG opcode was malformed. With the malformed opcode, the ASSERT/BUG_ON is skipped and the processor may execute another patch

Re: [Xen-devel] xen/arm: uart interrupts handling

2014-12-05 Thread Julien Grall
is raised but buffer is empty. I have added below changes to fix this on top of your suggested change Can you send a formal patch (commit message + signed-off-by)? Also, you will have to make sure you don't break the other serial drivers. Regards, -- Julien Grall

Re: [Xen-devel] Install Xen on ARM in a bare metal fashion on a Nexus Phone/Tablet or an ARM emulator

2014-12-05 Thread Julien Grall
the UART. So you should be able to get the log. For Xen, you will have to implement yourself the debug UART. -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen/serial: setup UART idle mode for OMAP

2014-12-05 Thread Julien Grall
understand how the kernel can configure the UART as the MMIO range is not mapped. Is there another way to set the idle mode? Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] have architectures specify the number of PIRQs a hardware domain gets

2014-12-05 Thread Julien Grall
On 05/12/14 14:42, Ian Campbell wrote: On Fri, 2014-12-05 at 14:36 +, Julien Grall wrote: Hi, On 05/12/14 14:27, Ian Campbell wrote: On Fri, 2014-12-05 at 13:51 +, Jan Beulich wrote: #define nr_static_irqs NR_IRQS +#define arch_hwdom_irqs(domid) NR_IRQS FWIW gic_number_lines

Re: [Xen-devel] [PATCH] have architectures specify the number of PIRQs a hardware domain gets

2014-12-05 Thread Julien Grall
the pirq to irq for the current-domain? Indeed, see also http://lists.xenproject.org/archives/html/xen-devel/2014-12/msg00219.html Do you plan to send a patch to resolve this problem? Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH] console: allocate ring buffer earlier

2014-12-05 Thread Julien Grall
console_init_preirq. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] console: allocate ring buffer earlier

2014-12-08 Thread Julien Grall
, end_boot_allocator is called in setup_mm which is called before console_init_preirq. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen/serial: setup UART idle mode for OMAP

2014-12-08 Thread Julien Grall
it has to be configured properly with Kernel 3.8 too. Your commit message suggests it works without any kind of workaround on this kernel version with Xen upstream. Can you update the commit message? Regards, -- Julien Grall ___ Xen-devel mailing list Xen

Re: [Xen-devel] [PATCH v3 2/2] x86, arm64, platform, xen, kconfig: add xen defconfig helper

2014-12-09 Thread Julien Grall
On 09/12/14 20:22, Luis R. Rodriguez wrote: On Tue, Dec 9, 2014 at 1:06 AM, Julien Grall julien.gr...@linaro.org wrote: Hello Luis, On 08/12/2014 23:05, Luis R. Rodriguez wrote: diff --git a/kernel/configs/xen.config b/kernel/configs/xen.config new file mode 100644 index 000..0d0eb6d

Re: [Xen-devel] [PATCH] domctl: fix IRQ permission granting/revocation

2014-12-10 Thread Julien Grall
, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Few Comments on the Xen SMMU ARM code

2014-12-11 Thread Julien Grall
are still testing on our board and can post a patch only after our testing is complete. I'm lost... I though PCI passthrough was working for you? So what's the status of the support? Regards, [1] http://lists.xen.org/archives/html/xen-devel/2014-11/msg00018.html -- Julien Grall

[Xen-devel] [PATCH for-4.6 3/4] xen/arm: vgic: notice if the vIRQ is not allocated when the guest enable it

2014-12-12 Thread Julien Grall
This help for guest interrupts debugging. If the vIRQ is not allocate, this means that nothing is wired to it. Signed-off-by: Julien Grall julien.gr...@linaro.org --- xen/arch/arm/vgic.c | 4 1 file changed, 4 insertions(+) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index

[Xen-devel] [PATCH for-4.6 2/4] xen/arm: vgic: Keep track of vIRQ used by a domain

2014-12-12 Thread Julien Grall
interrupt. Signed-off-by: Julien Grall julien.gr...@linaro.org --- xen/arch/arm/domain_build.c | 6 +++ xen/arch/arm/platforms/xgene-storm.c | 4 ++ xen/arch/arm/vgic.c | 76 xen/arch/arm/vtimer.c| 15 +++ xen

[Xen-devel] [PATCH for-4.6 1/4] xen/arm: vgic: Rename nr_lines into nr_spis

2014-12-12 Thread Julien Grall
by the emulated GIC. Signed-off-by: Julien Grall julien.gr...@linaro.org Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- It was part of the platform device passthrough series: https://patches.linaro.org/34661/ Stefano: I've kept your ack from the previous version. Let me know

[Xen-devel] [PATCH for-4.6 4/4] xen/arm: Find automatically a PPI for the DOM0 event channel interrupt

2014-12-12 Thread Julien Grall
to defer the allocation because no vIRQ can be injected as long as the vCPU is not online. Also correct the check in arch_domain_create to use is_hardware_domain. Signed-off-by: Julien Grall julien.gr...@linaro.org --- xen/arch/arm/domain.c| 13 ++--- xen/arch/arm

Re: [Xen-devel] [PATCH v2 2/2] x86, arm, platform, xen, kconfig: add xen defconfig helper

2014-12-15 Thread Julien Grall
+CONFIG_XEN_XENBUS_FRONTEND=y +CONFIG_XEN_GNTDEV=m +CONFIG_XEN_GRANT_DEV_ALLOC=m +CONFIG_SWIOTLB_XEN=y +CONFIG_XEN_PCIDEV_BACKEND=m +CONFIG_XEN_PRIVCMD=m +CONFIG_XEN_ACPI_PROCESSOR=m The common fragment config looks good for both ARM32 and ARM64: Acked-by: Julien Grall julien.gr...@linaro.org

Re: [Xen-devel] [PATCH v1] xen/arm: Manage pl011 uart TX interrupt correctly

2014-12-15 Thread Julien Grall
I don't think it's mandatory to have Keir's ack on this patch. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.6 2/4] xen/arm: vgic: Keep track of vIRQ used by a domain

2014-12-15 Thread Julien Grall
Hi Stefano, On 15/12/14 15:32, Stefano Stabellini wrote: On Fri, 12 Dec 2014, Julien Grall wrote: +spin_lock_init(d-arch.vgic.lock); you should probably explain in the commit message the reason why you are making changes to the vgic lock Actually the domain vgic lock was never used

[Xen-devel] [PATCH for 4.6 04/13] xen/dt: Extend dt_device_match to possibly store data

2014-12-16 Thread Julien Grall
Some drivers may want to configure differently the device depending on the compatible string. Also modify the return type of dt_match_node to return the matching structure. Signed-off-by: Julien Grall julien.gr...@linaro.org --- xen/arch/arm/platform.c | 2 +- xen/common/device_tree.c

[Xen-devel] [PATCH for 4.6 02/13] xen/arm: vgic: Drop unecessary include asm/device.h

2014-12-16 Thread Julien Grall
The header asm/device.h has been included in the vgic code during splitting to support multiple version. But no code within those files requires it. Signed-off-by: Julien Grall julien.gr...@linaro.org --- xen/arch/arm/vgic-v2.c | 1 - xen/arch/arm/vgic-v3.c | 1 - 2 files changed, 2 deletions

[Xen-devel] [PATCH for 4.6 11/13] xen/iommu: smmu: Check for duplicate stream IDs when registering master devices

2014-12-16 Thread Julien Grall
check for duplicates when DT information is parsed. Taken from the linux ML: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/226099.html Cc: Andreas Herrmann herrmann.der.u...@googlemail.com Signed-off-by: Andreas Herrmann andreas.herrm...@calxeda.com Signed-off-by: Julien Grall

[Xen-devel] [PATCH for 4.6 00/13] xen/arm: Resync the SMMU driver with the Linux one

2014-12-16 Thread Julien Grall
Sincerely yours, Andreas Herrmann (2): xen/iommu: smmu: Check for duplicate stream IDs when registering master devices xen/iommu: smmu: Introduce automatic stream-id-masking Julien Grall (11): xen/arm: gic-v2: Change the device name in DT_DEVICE_START xen/arm: vgic: Drop unecessary include

[Xen-devel] [PATCH for 4.6 07/13] xen: Introduce a generic way to describe device

2014-12-16 Thread Julien Grall
to compile ARM correctly. Signed-off-by: Julien Grall julien.gr...@linaro.org CC: Jan Beulich jbeul...@suse.com CC: Keir Fraser k...@xen.org --- xen/arch/arm/device.c | 2 +- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/gic-v2.c | 3 +-- xen/arch/arm/gic

[Xen-devel] [PATCH for 4.6 03/13] xen: Introduce ACCESS_ONCE macro

2014-12-16 Thread Julien Grall
This macro can be used in drivers imported from Linux. Signed-off-by: Julien Grall julien.gr...@linaro.org CC: Ian Jackson ian.jack...@eu.citrix.com CC: Jan Beulich jbeul...@suse.com CC: Keir Fraser k...@xen.org --- xen/include/xen/compiler.h | 14 ++ 1 file changed, 14 insertions

[Xen-devel] [PATCH for 4.6 01/13] xen/arm: gic-v2: Change the device name in DT_DEVICE_START

2014-12-16 Thread Julien Grall
I'm not sure why a ':' has been added in the name... But none of the other usages doesn't have it. Signed-off-by: Julien Grall julien.gr...@linaro.org --- xen/arch/arm/gic-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index

[Xen-devel] [PATCH for 4.6 12/13] xen/iommu: smmu: Introduce automatic stream-id-masking

2014-12-16 Thread Julien Grall
than num_streamids in the arm_smmu_free_smrs. This former is the field used to configure SRMS Cc: Andreas Herrmann herrmann.der.u...@googlemail.com Signed-off-by: Andreas Herrmann andreas.herrm...@calxeda.com Signed-off-by: Julien Grall julien.gr...@linaro.org --- xen/drivers/passthrough/arm

[Xen-devel] [PATCH for 4.6 10/13] xen/iommu: arm: Import the SMMU driver from Linux

2014-12-16 Thread Julien Grall
Based on commit e6b5be2be4e30037eb551e0ed09dd97bd00d85d3. It's a basic copy of the Linux SMMU drivers code. No Xen code has yet been added and not build. Compare to the previous drivers it gains support of PCI. Though it will need a bit of plumbing for Xen. Signed-of-by: Julien Grall julien.gr

[Xen-devel] [PATCH for 4.6 09/13] xen/arm: Describe device supported by a driver with dt_match_node

2014-12-16 Thread Julien Grall
Xen is currently using list a compatible string to know if the driver can use device node. This leads to have double definition in the GIC code. Futhermore Linux drivers is using dt_match_node (actually called of_device_id in Linux) to list device supported by the drivers. Signed-off-by: Julien

[Xen-devel] [PATCH for 4.6 08/13] xen/iommu: Consolidate device assignment ops into a single set

2014-12-16 Thread Julien Grall
On ARM, the way to assign device tree node is exactly the same as PCI. Futhermore, all devices can be represented by a struct device'. Therefore there is no need to add separate ops. Signed-off-by: Julien Grall julien.gr...@linaro.org CC: Suravee Suthikulpanit suravee.suthikulpa...@amd.com CC

Re: [Xen-devel] [PATCH v4] xmalloc: add support for checking the pool integrity

2014-12-16 Thread Julien Grall
Hi, On 16/12/2014 20:28, Andrew Cooper wrote: I suspect you also would be better, and certainly more brief, with run_in_exception_handler(show_stack) instead, which will just print a stack trace, but nothing more. FIY, run_in_exception_handler doesn't exists on ARM. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH v4] xmalloc: add support for checking the pool integrity

2014-12-16 Thread Julien Grall
On 16/12/2014 23:26, Andrew Cooper wrote: On 16/12/2014 23:06, Julien Grall wrote: Hi, On 16/12/2014 20:28, Andrew Cooper wrote: I suspect you also would be better, and certainly more brief, with run_in_exception_handler(show_stack) instead, which will just print a stack trace, but nothing

Re: [Xen-devel] [PATCH v4] xmalloc: add support for checking the pool integrity

2014-12-17 Thread Julien Grall
On 17/12/2014 10:11, Andrew Cooper wrote: On 16/12/14 23:37, Julien Grall wrote: Introducing a new bugframe is precicely what I meant by this doesn't look hard. x86 currently has one more bugframe than arm, being BUGFRAME_run_fn. And how do you pass the pointer of the function? As I said

Re: [Xen-devel] [PATCH for 4.6 07/13] xen: Introduce a generic way to describe device

2014-12-17 Thread Julien Grall
should try to find alternatives before adding such a construct that moves us in a direction opposite to getting our code more const-correct. Oh right. I didn't though about that case. I will turn this inline function into a macro. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH v4] xmalloc: add support for checking the pool integrity

2014-12-17 Thread Julien Grall
Hi Jan, On 17/12/14 10:40, Jan Beulich wrote: On 17.12.14 at 11:24, julien.gr...@linaro.org wrote: On 17/12/2014 10:11, Andrew Cooper wrote: On 16/12/14 23:37, Julien Grall wrote: Introducing a new bugframe is precicely what I meant by this doesn't look hard. x86 currently has one more

Re: [Xen-devel] [PATCH for 4.6 03/13] xen: Introduce ACCESS_ONCE macro

2014-12-17 Thread Julien Grall
, all running on the same CPU. + */ +#define ACCESS_ONCE(x) (*(volatile typeof(x) *)(x)) Any reason not to simply use {read,write}_atomic() instead, which we already have? To avoid modifying Linux drivers when it's not necessary and doesn't harm. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH for 4.6 07/13] xen: Introduce a generic way to describe device

2014-12-17 Thread Julien Grall
(), and that type can't be both const and non-const at the same time, i.e. you can't easily inherit the const-ness of the passed in pointer. I agree that we will drop the const-ness. But is it really an issue? We won't have many place where we don't want to modify the pci_dev. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH for-4.6 2/4] xen/arm: vgic: Keep track of vIRQ used by a domain

2014-12-17 Thread Julien Grall
On 15/12/14 16:07, Julien Grall wrote: On 15/12/14 15:32, Stefano Stabellini wrote: On Fri, 12 Dec 2014, Julien Grall wrote: +spin_lock_init(d-arch.vgic.lock); you should probably explain in the commit message the reason why you are making changes to the vgic lock Actually the domain

[Xen-devel] [PATCH for 4.5] xen/arm: Initialize the domain vgic lock

2014-12-17 Thread Julien Grall
The domain vgic lock is used uninitialized. Signed-off-by: Julien Grall julien.gr...@linaro.org --- This is a bug fix for Xen 4.5 and Xen 4.4. The vgic lock is used unitialized. Luckily we only use the field raw which is reset to 0 during the domain allocation. There is no harm

Re: [Xen-devel] [PATCH for 4.6 07/13] xen: Introduce a generic way to describe device

2014-12-18 Thread Julien Grall
, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for 4.5] xen/arm: Initialize the domain vgic lock

2014-12-18 Thread Julien Grall
Hi Ian, On 18/12/2014 09:47, Ian Campbell wrote: On Wed, 2014-12-17 at 15:40 +, Julien Grall wrote: The domain vgic lock is used uninitialized. Signed-off-by: Julien Grall julien.gr...@linaro.org Acked-by: Ian Campbell ian.campb...@citrix.com --- This is a bug fix for Xen 4.5

Re: [Xen-devel] [PATCH for 4.5] xen/arm: Initialize the domain vgic lock

2014-12-18 Thread Julien Grall
On 18/12/2014 12:12, Ian Campbell wrote: On Thu, 2014-12-18 at 12:05 +, Julien Grall wrote: Hi Ian, On 18/12/2014 09:47, Ian Campbell wrote: On Wed, 2014-12-17 at 15:40 +, Julien Grall wrote: The domain vgic lock is used uninitialized. Signed-off-by: Julien Grall julien.gr

Re: [Xen-devel] [PATCH for 4.6 07/13] xen: Introduce a generic way to describe device

2014-12-18 Thread Julien Grall
Hi Jan, On 17/12/2014 17:17, Jan Beulich wrote: Julien Grall julien.gr...@linaro.org 12/17/14 2:04 PM On 17/12/14 10:46, Jan Beulich wrote: On 17.12.14 at 11:30, julien.gr...@linaro.org wrote: Having a generic way to describe device will really help ARM code (see IOMMU). If we don't have

Re: [Xen-devel] [PATCH for 4.6 03/13] xen: Introduce ACCESS_ONCE macro

2014-12-18 Thread Julien Grall
Hi Andrew Cooper, On 17/12/2014 17:52, Andrew Cooper wrote: On 17/12/14 17:10, Jan Beulich wrote: Julien Grall julien.gr...@linaro.org 12/17/14 1:55 PM On 17/12/14 10:05, Jan Beulich wrote: On 16.12.14 at 21:08, julien.gr...@linaro.org wrote: +#define ACCESS_ONCE(x) (*(volatile typeof(x

  1   2   3   4   5   6   7   8   9   10   >